Subject: Re: New version of the device tree aware EMAC driver

From: Valentine Barshak <[email-masked]>
Date: Wed, 16 May 2007 21:00:25 +0400

David Gibson wrote:
> I've made a few more tiny tweaks to BenH's rewritten device-tree based
> 4xx EMAC driver.  The main change is that it now no longer requires
> 'device_type', just 'compatible' to be set in the ZMII and MAL device
> nodes when probing.  This works better with current thinking on
> flattened device trees which discourages creating new device_type
> values unless there is a clear use for a new device class binding.
>
> The patch can be obtained from:
>
> http://ozlabs.org/~dgibson/home/emac/powerpc-emac-new-20070516.patch
>
>   
In __emac_mdio_read and __emac_mdio_write functions:

+    if (!emac_has_feature(dev, EMAC_FTR_STACR_OC_INVERT))
+        r |= EMAC_STACR_OC;

should be

+    if (emac_has_feature(dev, EMAC_FTR_STACR_OC_INVERT))
+        r |= EMAC_STACR_OC;

Thanks.