Subject: Re: [PATCH 2/5] Add legacy devices to mpc8641_hpcn.dts

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 17 May 2007 00:03:26 +0400

Hello.

Segher Boessenkool wrote:

>>>+				8042@60 {
>>>+					device_type = "8042";

> Drop the device_type.  A number as a name isn't
> all that great, either.

    Perhaps it should be called "keyboard" (and device_type should also be set 
to it) since 8042 is in fact (mostly) a keyboard controller... although it 
also "drives" PS/2 mouse...

>>>+				rtc@70 {
>>>+					device_type = "rtc";
>>>+					reg = <1 70 2>;
>>>+				};

>>Is "rtc" a standard OF device,

> Yes, it is defined in the "Device Support Extensions"
> recommended practice.

    And it also defines "keyboard".

WBR, Sergei