From: Dragos Carp <dragos.carp@toptica•com>
To: Sylvain Munaut <tnt@246tNt•com>
Cc: David Brownell <david-b@pacbell•net>,
spi-devel-general@lists•sourceforge.net,
Domen Puncer <domen@coderock•org>,
linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] mpc52xx_psc_spi: fix it for CONFIG_PPC_MERGE
Date: Fri, 18 May 2007 09:44:17 +0200 [thread overview]
Message-ID: <464D5951.7070602@toptica.com> (raw)
In-Reply-To: <464B329E.8030600@246tNt.com>
Sylvain Munaut wrote:
> David Brownell wrote:
>
>> On Wednesday 16 May 2007, Sylvain Munaut wrote:
>>
>>
>>> Well, this comment is not about the patch but about the driver it self,
>>> I didn't see it before today.
>>>
>>>
>> It merged earlier in the 2.6.22 cycle. If you don't have criticisms
>> about the patch itself, I'll forward it for merging after I get at
>> least an ack from Dragos.
>>
>>
> Yes, I saw when looking at the spi-devl archive. Would have been nice if the
> author though of cc-ing the ppc-embedded list ;)
>
>
Sorry about not cc-ing ppc-embedded, this was my first kernel patch, I'm
not very familiar with the submitting process.
> The patch looks ok to me (and needed actually since as Domen pointed
> out, 52xx
> has been replaced by 5200 in the device tree).
> And cell-index has been added to know the psc id without dirty tricks.
>
>
The patch looks ok. I'm currently still using 2.6.20 which still has
52xx. I compiled it for 2.6.22-rc2 and of course this problem was not
caught by the compiler. Unfortunately for the board that I'm using
(MPC5200-tiny from Pythec), there is no adaptation yet for 2.6.21.
>>> - MPC52xx_PA(MPC52xx_PSCx_OFFSET(...)) ??? You should get that from the
>>> resource of the platform_device. This macro is just there for early
>>> console stuff.
>>>
>>>
>> That PPC_MERGE stuff does look messy.
>>
>>
> Yes, trying to support both in a driver is really not pretty.
> Once we can finally get rid of it I'll submit a patch to clear that out.
>
>
A clean up for PPC_MERGE will be nice. There are still some magic
numbers used in the driver (SICR_SIM_CODEC8, SICR_GENCLK, etc..) that
should be defined in mpc52xx_psc.h.
Dragos
next prev parent reply other threads:[~2007-05-18 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 7:37 [PATCH] mpc52xx_psc_spi: fix it for CONFIG_PPC_MERGE Domen Puncer
2007-05-16 8:19 ` Sylvain Munaut
2007-05-16 16:11 ` David Brownell
2007-05-16 16:34 ` Sylvain Munaut
2007-05-18 7:44 ` Dragos Carp [this message]
2007-05-25 8:43 ` [RFC 1/3] " Domen Puncer
2007-05-25 14:50 ` Sylvain Munaut
2007-05-25 17:02 ` Grant Likely
2007-05-25 8:45 ` [RFC 2/3] " Domen Puncer
2007-05-25 8:47 ` [RFC 3/3] " Domen Puncer
2007-05-25 16:34 ` David Brownell
2007-05-25 18:00 ` Domen Puncer
2007-05-21 7:31 ` Dragos Carp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464D5951.7070602@toptica.com \
--to=dragos.carp@toptica$(echo .)com \
--cc=david-b@pacbell$(echo .)net \
--cc=domen@coderock$(echo .)org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=spi-devel-general@lists$(echo .)sourceforge.net \
--cc=tnt@246tNt$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox