From: Scott Wood <scottwood@freescale•com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 10/13] mpc83xx: Power Management support
Date: Tue, 22 May 2007 16:16:55 -0500 [thread overview]
Message-ID: <46535DC7.6080807@freescale.com> (raw)
In-Reply-To: <Pine.LNX.4.60.0705222301070.4243@poirot.grange>
Guennadi Liakhovetski wrote:
>>+ /* There can only be one fsl,mpc83xx-pmc device in the system;
>>+ * it is assumed that it is the one that the pmc driver matches.
>>+ */
>>+ if (of_device_is_compatible(sleep_controller, "fsl,mpc83xx-pmc")) {
>>+ sleep->sccr_mask = sleepdata[1];
>>+ ret = 0;
>>+ }
>
>
> Just wondering - do we really want to special-case 83xx-pmc here? What
> when / if further "sleep controllers" get implemented? Shouldn't this be
> some callback?
The quick and ugly thing would be more if checks. The ideal solution
would be a mechanism to look up a device by phandle, returning an ops
struct corresponding to the requested class (if the device supports it).
> BTW, do we have an interface similar to platform-driver/device for of?
> Like of_driver/device. This would be a use case for it. Just register a
> of_driver, which would trigger a dt-scan (just a find_compatible), calling
> driver's probe()... Would it make sense?
See asm-powerpc/of_platform.h. However, that won't help find the driver
you need to talk to if all you have is a phandle.
-Scott
next prev parent reply other threads:[~2007-05-22 21:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 18:29 [PATCH 01/13] Clean up formatting in Documentation/booting-without-of.txt Scott Wood
2007-05-07 18:29 ` [PATCH 02/13] Document devtree binding for power management controllers Scott Wood
2007-05-08 0:19 ` David Gibson
2007-05-07 18:29 ` [PATCH 03/13] Document the sleep property Scott Wood
2007-05-08 2:11 ` Olof Johansson
2007-05-08 15:23 ` Scott Wood
2007-05-07 18:29 ` [PATCH 04/13] Document the devtree binding for general purpose timers Scott Wood
2007-05-07 18:29 ` [PATCH 05/13] Document the fsl, magic-packet property in gianfar nodes Scott Wood
2007-05-07 21:27 ` Andy Fleming
2007-05-07 21:29 ` Scott Wood
2007-05-07 21:51 ` Andy Fleming
2007-05-07 23:06 ` Kumar Gala
2007-05-08 0:18 ` David Gibson
2007-05-09 14:33 ` Segher Boessenkool
2007-05-09 18:26 ` Scott Wood
2007-05-10 6:57 ` Segher Boessenkool
2007-05-08 15:29 ` Scott Wood
2007-05-07 18:29 ` [PATCH 06/13] Make swsusp_32.S usable for suspend-to-RAM Scott Wood
2007-05-07 18:29 ` [PATCH 07/13] Implement arch disable/enable irq hooks Scott Wood
2007-05-21 15:55 ` Johannes Berg
2007-05-22 7:14 ` Benjamin Herrenschmidt
2007-05-22 9:03 ` Johannes Berg
2007-05-22 9:15 ` Benjamin Herrenschmidt
2007-05-22 9:24 ` Johannes Berg
2007-05-07 18:29 ` [PATCH 08/13] pm: Handle HID0_SLEEP in the TLF_NAPPING hack Scott Wood
2007-05-07 18:29 ` [PATCH 09/13] fsl_soc: Factor fsl_get_bus_freq() out of the wdt init Scott Wood
2007-05-10 3:36 ` Kumar Gala
2007-05-10 15:49 ` Scott Wood
2007-05-10 15:59 ` Kumar Gala
2007-05-07 18:29 ` [PATCH 10/13] mpc83xx: Power Management support Scott Wood
2007-05-22 21:08 ` Guennadi Liakhovetski
2007-05-22 21:16 ` Scott Wood [this message]
2007-05-07 18:29 ` [PATCH 11/13] mpc83xx: timer driver for PM wakeup Scott Wood
2007-05-07 18:29 ` [PATCH 12/13] gianfar: Add flags for magic packet and MDIO Scott Wood
2007-05-07 19:52 ` Kumar Gala
2007-05-07 19:54 ` Scott Wood
2007-05-07 20:00 ` Kumar Gala
2007-05-07 21:25 ` Andy Fleming
2007-05-07 21:31 ` Scott Wood
2007-05-07 21:56 ` Andy Fleming
2007-05-07 21:45 ` Andy Fleming
2007-05-07 21:53 ` Scott Wood
2007-05-07 21:59 ` Andy Fleming
2007-05-07 23:11 ` Kumar Gala
2007-05-07 23:36 ` Andy Fleming
2007-05-07 18:30 ` [PATCH 13/13] gianfar: Magic Packet and suspend/resume support Scott Wood
2007-05-08 0:20 ` [PATCH 01/13] Clean up formatting in Documentation/booting-without-of.txt David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46535DC7.6080807@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox