public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Dave Jiang <djiang@mvista•com>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
	David Gibson <david@gibson•dropbear.id.au>
Subject: Re: Fix compiler/assembler flags for Ebony platform boot files
Date: Fri, 25 May 2007 08:01:52 -0700	[thread overview]
Message-ID: <4656FA60.7080600@mvista.com> (raw)
In-Reply-To: <1180101877.3360.39.camel@zod.rchland.ibm.com>

Josh Boyer wrote:
> On Fri, 2007-05-25 at 13:19 +1000, David Gibson wrote:
>> The recent addition of assembler flags for 44x.c and ebony.c in the
>> bootwrapper to make them compile on certain toolchains was not correct
>> and could break other platforms.  This patch switches to using a
>> compiler flag instead, which implies the appropriate assembler flag,
>> and also stops the compiler itself generating instructions which are
>> invalid for the platform in question.
> 
> This looks good to me, but I don't have one of the failing toolchains.
> Dave, can you test this patch out?
> 
> josh
> 

Built ok for me after the patch.

  parent reply	other threads:[~2007-05-25 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  3:19 Fix compiler/assembler flags for Ebony platform boot files David Gibson
2007-05-25 14:04 ` Josh Boyer
2007-05-25 14:28   ` Segher Boessenkool
2007-05-25 15:01   ` Dave Jiang [this message]
2007-05-25 14:05 ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4656FA60.7080600@mvista.com \
    --to=djiang@mvista$(echo .)com \
    --cc=david@gibson$(echo .)dropbear.id.au \
    --cc=jwboyer@linux$(echo .)vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox