Subject: Re: [PATCH] powerpc: automatically select QE options

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 28 May 2007 21:43:14 +0400

Hello.

Timur Tabi wrote:

> Change the Kconfig files so that the Freescale QE options are automatically
> selected if a QE device is selected.  Previously, you'd need to manually
> select UCC_FAST if you want any "fast" UCC devices, such as Gigabit Ethernet.
> Now, the QE Gigabit Ethernet option is always available if the device has a
> QE, and UCC_FAST is automatically enabled.  A side-effect is that the
> "QE Options" menu no longer exists.

> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index d9400ef..b92a4e6 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2272,11 +2272,12 @@ config GFAR_NAPI
>  	depends on GIANFAR
>  
>  config UCC_GETH
> -	tristate "Freescale QE UCC GETH"
> -	depends on QUICC_ENGINE && UCC_FAST
> +	tristate "Freescale QE Gigabit Ethernet"
> +	depends on QUICC_ENGINE
> +	select UCC_FAST

    Grr... this causes menuconfig to complain on non-PPC archs:

drivers/net/Kconfig:2278:warning: 'select' used by config symbol 'UCC_GETH' 
refer to undefined symbol 'UCC_FAST'

WBR, Sergei