From: Andrei Konovalov <akonovalov@ru•mvista.com>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx•com>
Cc: spi-devel-general@lists•sourceforge.net, linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] Simple driver for Xilinx SPI controler.
Date: Wed, 06 Jun 2007 21:57:44 +0400 [thread overview]
Message-ID: <4666F598.2000004@ru.mvista.com> (raw)
In-Reply-To: <20070606160329.A8A719E0060@mail81-sin.bigfish.com>
Hi Steve,
Stephen Neuendorffer wrote:
> In order to anticipate future Microblaze support with most of these
> drivers,
> we've been moving towards having all of the Kconfig dependencies on
> XILINX_EDK,
There is no XILINX_EDK in the ko tree.
> rather than XILINX_VIRTEX...
Using XILINX_VIRTEX seems to be a common thing:
> -------- Original Message --------
> Subject: [RFC] Xilinx SystemACE device driver
> Date: Sat, 14 Apr 2007 19:23:14 -0600
> From: Grant Likely <grant.likely@secretlab•ca>
> To: linuxppc-embedded@ozlabs•org, Andrei Konovalov <akonovalov@ru•mvista.com>, Peter Korsgaard <jacmet@sunsite•dk>, Rick Moleres <Rick.Moleres@xilinx•com>, Stefan Roese <sr@denx•de>
>
> Add support for block device access to the Xilinx SystemACE Compact
> flash interface
<snip>
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 17ee97f..08ad23c 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -453,6 +453,12 @@ config ATA_OVER_ETH
> This driver provides Support for ATA over Ethernet block
> devices like the Coraid EtherDrive (R) Storage Blade.
>
> +config XILINX_SYSACE
> + tristate "Xilinx SystemACE support"
> + depends on XILINX_VIRTEX
> + help
> + Include support for the Xilinx SystemACE CompactFlash interface
> +
BTW the SystemACE has been successfully tested with ppc440 based
board. So XILINX_VIRTEX doesn't imply ppc405.
On the other side,
UART Lite driver (in the ko tree) doesn't depend on both XILINX_EDK and XILINX_VIRTEX
Couldn't Microblaze port use XILINX_VIRTEX too?
IMHO XILINX_VIRTEX is more general name for something inside the Virtex chip (ppc405
core, Microblaze softcore, IP blocks from EDK or elsewhere).
I've recently added XILINX_EDK to linux-xilinx-26.git repository at source.mvista.com,
but to include the level 1 drivers (aka OS independent drivers) from EDK. Haven't
planned to use XILINX_EDK for drivers not using EDK code.
Here is the relevant snippet from arch/ppc/platforms/4xx/Kconfig
(from linux-xilinx-26.git @ source.mvista.com, ko doesn't have XILINX_EDK and the
rest below):
===8<=====================================
config XILINX_VIRTEX_II_PRO
bool
select XILINX_VIRTEX
config XILINX_VIRTEX_4_FX
bool
select XILINX_VIRTEX
config XILINX_VIRTEX
bool
# The options selected by EDK based drivers. Not visible from [menu]config.
config XILINX_EDK
bool
config XILINX_IPIF_V123B
bool
config XILINX_FIFO_V200A
bool
config XILINX_DMA_V300A
bool
===8<=====================================
If we do something like
config XILINX_MICROBLAZE
bool
select XILINX_VIRTEX
in arch/microblaze/Kconfig
would it work?
Thanks,
Andrei
next prev parent reply other threads:[~2007-06-06 17:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 14:05 [PATCH] Simple driver for Xilinx SPI controler Andrei Konovalov
2007-06-06 16:03 ` Stephen Neuendorffer
2007-06-06 17:57 ` Andrei Konovalov [this message]
2007-06-06 18:06 ` Stephen Neuendorffer
2007-06-06 19:00 ` Grant Likely
2007-06-06 19:06 ` Stephen Neuendorffer
2007-06-06 19:55 ` Grant Likely
2007-06-07 13:50 ` Andrei Konovalov
2007-06-06 20:49 ` Wolfgang Reissnegger
2007-06-06 20:55 ` Grant Likely
2007-06-07 5:09 ` [spi-devel-general] " David Brownell
2007-06-07 18:39 ` Andrei Konovalov
2007-06-07 19:21 ` David Brownell
2007-06-09 16:58 ` Andrei Konovalov
2007-06-12 16:28 ` David Brownell
2007-06-13 14:55 ` Andrei Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666F598.2000004@ru.mvista.com \
--to=akonovalov@ru$(echo .)mvista.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=spi-devel-general@lists$(echo .)sourceforge.net \
--cc=stephen.neuendorffer@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox