Subject: Re: [patch 02/18] PS3: Rename IPI symbols

From: Geoff Levand <[email-masked]>
Date: Wed, 06 Jun 2007 13:47:58 -0700

Will Schmidt wrote:
> On Wed, 2007-06-06 at 13:11 +1000, Stephen Rothwell wrote:
>> On Tue, 05 Jun 2007 19:59:25 -0700 Geoff Levand <[email-masked]> wrote:
>> >
>> > Rename the PS3 static symbol virqs to ps3_ipi_virqs to aid in
>> > debugging.
>> > 
>> > Signed-off-by: Geoff Levand <[email-masked]>
>> >
>> >  	for (i = 0; i < MSG_COUNT; i++) {
>> > -		free_irq(virqs[i], (void*)(long)i);
>> > +		/* Can't call free_irq from interrupt context. */
>> 
>> This change is probably worth a mention in the change log - it looks like
>> a bug fix.
> 
> 
> Does the free_irq call (being removed here) need to be added back in
> somewhere else? 

No, the kernel is kexecing, so it is not needed.

-Geoff