Subject: Re: [PATCH] Fix I8042 IRQs on MPC8641 HPCN

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 20 Jun 2007 20:04:54 +0400

Segher Boessenkool wrote:
>> 	 * IRQ 9:  Level
>> 	 * IRQ 10: Level
>> 	 * IRQ 11: Level
>>-	 * IRQ 12: Level
>>+	 * IRQ 12: Edge
>> 	 * IRQ 14: Edge
>> 	 * IRQ 15: Edge
>> 	 */
>>-	outb(0xfa, 0x4d0);
>>-	outb(0x1e, 0x4d1);
>>+	outb(0xf8, 0x4d0);
>>+	outb(0x0e, 0x4d1);
> 
> 
> The comment doesn't mention IRQ13.  You're changing IRQ9
> to edge as well; is this an accident?

    Whare -- I'm only seeing bit 1 changing which corresponds to IRQ1 and is 
reserved (0) anyway.

>  If not, you need
> to change the comment too.

WBR, Sergei