From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: David Woodhouse <dwmw2@infradead•org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org, Arnd Bergmann <arnd@arndb•de>
Subject: Re: [PATCH] Handle reg-shift property for of_serial ports
Date: Sat, 07 Jul 2007 21:07:21 +0400 [thread overview]
Message-ID: <468FC849.20801@ru.mvista.com> (raw)
In-Reply-To: <1183827083.3066.64.camel@shinybook.infradead.org>
Hello.
David Woodhouse wrote:
>>Given the existence of the boards, it looks correct to do this.
>>However, I wonder if it was correct for the MV64660 to claim
>>compatibily witn ns16550 if the programming model is not exactly
>>the same. The official OF serial port bindings don't mention the
>>reg-shift property, so it maybe would have been better to have
I'd preferred "reg-stride" or "reg-size" but see below...
>>a different value for the "compatible" property, in order not
>>to confuse existing operating systems that implement the standard.
> Ok, how about 'sparse16550'? Otherwise identical to ns16550, but with
Erm, wouldn't it be *too* generic approach? I'd suggest to name the
device with its own name and make of_serial.c recognize it and register with
8250.c as needed.
> the reg-shift property. I'll send a patch shortly, and I'll reorder the
> match table -- if something claims compatibility with both 8250 and
> 16550, shouldn't we drive it as the latter?
Certainly. BTW, was there really "ns8250" -- 8250 is Intel's chip?
WBR, Sergei
next prev parent reply other threads:[~2007-07-07 17:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 4:58 [PATCH] Handle reg-shift property for of_serial ports David Woodhouse
2007-07-07 12:10 ` Arnd Bergmann
2007-07-07 14:59 ` David Woodhouse
2007-07-07 16:51 ` David Woodhouse
2007-07-07 17:07 ` Sergei Shtylyov [this message]
2007-07-07 17:52 ` Arnd Bergmann
2007-07-07 22:15 ` Segher Boessenkool
2007-07-07 22:12 ` Segher Boessenkool
2007-07-07 17:55 ` Arnd Bergmann
2007-07-07 22:21 ` Segher Boessenkool
2007-07-07 22:06 ` Segher Boessenkool
2007-07-07 16:57 ` [PATCH 1/2] Add 'sparse16550' to of_serial.c and handle 'reg-shift' property David Woodhouse
2007-07-07 16:57 ` [PATCH 2/2] Add 'sparse16550' support to PowerPC bootwrapper David Woodhouse
2007-07-07 22:23 ` [PATCH] Handle reg-shift property for of_serial ports Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468FC849.20801@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=arnd@arndb$(echo .)de \
--cc=dwmw2@infradead$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox