From: Andrei Konovalov <akonovalov@ru•mvista.com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] xilinxfb: Parameterize xilinxfb platform device registration
Date: Tue, 10 Jul 2007 12:34:30 +0400 [thread overview]
Message-ID: <46934496.40805@ru.mvista.com> (raw)
In-Reply-To: <20070709235105.4826.79342.stgit@trillian>
Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab•ca>
>
> This patch allows multiple xilinxfb devices to be registered and used
>
> Signed-off-by: Grant Likely <grant.likely@secretlab•ca>
> cc: Andrei Konovalov <akonovalov@ru•mvista.com>
> ---
Looks OK for me.
Thanks,
Andrei
> arch/ppc/syslib/virtex_devices.c | 38 +++++++++++++++++++++++++-------------
> 1 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/arch/ppc/syslib/virtex_devices.c b/arch/ppc/syslib/virtex_devices.c
> index 83f978f..9b473cf 100644
> --- a/arch/ppc/syslib/virtex_devices.c
> +++ b/arch/ppc/syslib/virtex_devices.c
> @@ -152,6 +152,21 @@
> }, \
> }
>
> +/*
> + * ML300/ML403 Video Device: shortcut macro for single instance
> + */
> +#define XPAR_TFT(num) { \
> + .name = "xilinxfb", \
> + .id = num, \
> + .num_resources = 1, \
> + .resource = (struct resource[]) { \
> + { \
> + .start = XPAR_TFT_##num##_BASEADDR, \
> + .end = XPAR_TFT_##num##_BASEADDR+7, \
> + .flags = IORESOURCE_IO, \
> + }, \
> + }, \
> +}
>
> /* UART 8250 driver platform data table */
> struct plat_serial8250_port virtex_serial_platform_data[] = {
> @@ -274,20 +289,17 @@ struct platform_device virtex_platform_devices[] = {
> #endif
> #endif
>
> - /* ML300/403 reference design framebuffer */
> #if defined(XPAR_TFT_0_BASEADDR)
> - {
> - .name = "xilinxfb",
> - .id = 0,
> - .num_resources = 1,
> - .resource = (struct resource[]) {
> - {
> - .start = XPAR_TFT_0_BASEADDR,
> - .end = XPAR_TFT_0_BASEADDR+7,
> - .flags = IORESOURCE_IO,
> - },
> - },
> - },
> + XPAR_TFT(0),
> +#endif
> +#if defined(XPAR_TFT_1_BASEADDR)
> + XPAR_TFT(1),
> +#endif
> +#if defined(XPAR_TFT_2_BASEADDR)
> + XPAR_TFT(2),
> +#endif
> +#if defined(XPAR_TFT_3_BASEADDR)
> + XPAR_TFT(3),
> #endif
> };
>
next prev parent reply other threads:[~2007-07-10 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 23:51 [PATCH] xilinxfb: Parameterize xilinxfb platform device registration Grant Likely
2007-07-10 8:34 ` Andrei Konovalov [this message]
2007-07-10 14:56 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46934496.40805@ru.mvista.com \
--to=akonovalov@ru$(echo .)mvista.com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox