Subject: Re: [PATCH 32/61] mpc82xx: Move PQ2 restart and halt functions out of mpc8272-specific code.

From: Scott Wood <[email-masked]>
Date: Wed, 18 Jul 2007 11:33:44 -0500

Kumar Gala wrote:
> Kill pq2_halt, if this is all it does just dont set ppc_md.halt() and  
> get the generic behavior which is the same.

OK.

>> diff --git a/include/asm-ppc/immap_cpm2.h b/include/asm-ppc/ immap_cpm2.h
>> index 3c23d9c..8795bcc 100644
>> --- a/include/asm-ppc/immap_cpm2.h
>> +++ b/include/asm-ppc/immap_cpm2.h
>> @@ -10,6 +10,8 @@
>>  #ifndef __IMMAP_CPM2__
>>  #define __IMMAP_CPM2__
>>
>> +#include <linux/types.h>
>> +
> 
> 
> Why was this needed all of a sudden?

It uses types without including any headers.  It's always been needed, 
we just got away with it before because the file including immap_cpm2.h 
included other stuff earlier.

-Scott