Subject: Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

From: Scott Wood <[email-masked]>
Date: Wed, 18 Jul 2007 13:56:01 -0500

Milton Miller wrote:
> In-Reply-To: <[email-masked]>
> 
> On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote:
> 
>> 1. ft_create_node was returning the internal pointer rather than a 
>> phandle.
>> 2. ft_find_device_rel was treating lookups relative to root as an error.
> 
> 
> No, it is treating lookups relative to NULL as an error.
> 
> Your patch changes it to treat lookups relative to the NULL phandle as 
> relative to root.

Other parts of the code (such as ft_create_node) already do that. 
What's wrong with it?

> I've no objections to the other part, can you split these?

No, because change #1 won't work without change #2.

-Scott