public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Ned Forrester <nforrester@whoi•edu>
To: David Brownell <david-b@pacbell•net>
Cc: spi-devel-general@lists•sourceforge.net,
	Stephen Street <stephen@streetfiresound•com>,
	linuxppc-dev@ozlabs•org
Subject: Re: [spi-devel-general] [PATCH 2/3] [SPI] Add new mode: SPI_LOOP
Date: Thu, 26 Jul 2007 23:34:45 -0400	[thread overview]
Message-ID: <46A967D5.30606@whoi.edu> (raw)
In-Reply-To: <200707262007.07537.david-b@pacbell.net>

David Brownell wrote:
> On Thursday 26 July 2007, Anton Vorontsov wrote:
>> Loopback mode is supported by various controllers, this mode
>> is useful for testing, especially in conjunction with spidev
>> driver.
> 
> ISTR that Stephen Street provided a loopback mode for debug
> in his pxa2xx_spi code.  And I know you're fight that this
> mode shows up in a lot of hardware.
> 
> Comments, anyone?  This seems like a fair way to expose this
> mechanism.  And I tend to agree that it'd mostly be useful in
> conjunction with "spidev".

Yes, it is in pxa2xx_spi.  It is passed in a structure that is attached 
to spi_board_info.controller_data.  I have used it to great effect to 
test data modes in the driver for which I have no external hardware 
support: various bits/word, clock frequencies, fifo thresholds, dma 
burst sizes, etc.

It works for me if this is moved to struct spi_device.

I don't think I have any code that could be readily turned into a 
generic test program.

-- 
Ned Forrester                                       nforrester@whoi•edu
Oceanographic Systems Lab                                  508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution          Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079

  reply	other threads:[~2007-07-27  4:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 13:47 [PATCH 0/3] [SPI] loopback mode support, [POWERPC] loopback mode for spi_mpc83xx Anton Vorontsov
2007-07-26 13:50 ` [PATCH 1/3] [SPI] Sync spidev.{h,c} with spi.h Anton Vorontsov
2007-07-27  3:02   ` [spi-devel-general] [PATCH 1/3] [SPI] Sync spidev.{h, c} " David Brownell
2007-07-26 13:50 ` [PATCH 2/3] [SPI] Add new mode: SPI_LOOP Anton Vorontsov
2007-07-27  3:07   ` [spi-devel-general] " David Brownell
2007-07-27  3:34     ` Ned Forrester [this message]
2007-08-01 18:25       ` David Brownell
2007-07-27 13:27     ` Anton Vorontsov
2007-07-26 13:51 ` [PATCH 3/3] [POWERPC][SPI] spi_mpc83xx: add support for loopback mode Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A967D5.30606@whoi.edu \
    --to=nforrester@whoi$(echo .)edu \
    --cc=david-b@pacbell$(echo .)net \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=spi-devel-general@lists$(echo .)sourceforge.net \
    --cc=stephen@streetfiresound$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox