From: Dave Jiang <djiang@mvista•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: linuxppc-dev@ozlabs•org, norsk5@yahoo•com,
bluesmoke-devel@lists•sourceforge.net
Subject: Re: [PATCH 2/2] powerpc: MPC85xx EDAC device driver
Date: Mon, 30 Jul 2007 10:48:55 -0700 [thread overview]
Message-ID: <46AE2487.7060103@mvista.com> (raw)
In-Reply-To: <200707301928.51253.arnd@arndb.de>
Arnd Bergmann wrote:
> On Monday 30 July 2007, Dave Jiang wrote:
>> Arnd Bergmann wrote:
>
>>> I'd suggest either to integrate EDAC into the 85xx specific PCI code,
>>> or to have an extra device in the device tree for this.
>> How about I create a platform device just for EDAC and leave the PCI of_device
>> to the 85xx PCI code? That would be a lot less modification than adding a
>> device for every PCI hose per DTS file.... Just a thought....
>
> Hmm, I can see your point about not having to change all the device trees,
> but if you really want to have a device for each of them, an of_device seems
> more natural to me than a platform_device.
>
> What about the other option I mentioned, handling the EDAC stuff from the
> fsl_add_bridge() function?
I'm not sure I follow your thought on this quite yet. Do you mean the setup of
either of_device or platform_device or do you mean the actual pci err driver?
I'm not understanding how doing the setup code in fsl_add_bridge() would allow
us to prevent the of_device being monopolized by the EDAC driver or the future
PCI code.... The EDAC driver still needs some sort of "device" to claim one way
or another right?
Of course I can go ahead and add the PCI err device in the DTS files for all
85xx if Kumar is okay with that idea....
--
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
next prev parent reply other threads:[~2007-07-30 17:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 22:22 [PATCH 2/2] powerpc: MPC85xx EDAC device driver Dave Jiang
2007-07-29 14:06 ` Arnd Bergmann
2007-07-30 16:40 ` Dave Jiang
2007-07-30 17:28 ` Arnd Bergmann
2007-07-30 17:48 ` Dave Jiang [this message]
2007-07-30 18:46 ` Arnd Bergmann
2007-07-30 19:29 ` Dave Jiang
2007-07-30 19:58 ` Arnd Bergmann
2007-07-30 20:17 ` Dave Jiang
2007-07-30 21:44 ` Linas Vepstas
2007-07-30 22:47 ` Doug Thompson
2007-08-01 19:48 ` EDAC & PCI error recovery (was Re: [PATCH 2/2] powerpc: MPC85xx EDAC device driver) Linas Vepstas
2007-08-01 20:34 ` EDAC stats " Doug Thompson
2007-07-30 22:58 ` [PATCH 2/2] powerpc: MPC85xx EDAC device driver Dave Jiang
2007-07-31 20:49 ` Dave Jiang
2007-07-31 22:07 ` Arnd Bergmann
2007-07-31 22:24 ` Dave Jiang
2007-07-31 22:25 ` Arnd Bergmann
2007-08-01 0:16 ` Dave Jiang
2007-08-01 8:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE2487.7060103@mvista.com \
--to=djiang@mvista$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bluesmoke-devel@lists$(echo .)sourceforge.net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=norsk5@yahoo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox