From: "Chris Friesen" <cfriesen@nortel•com>
To: linuxppc-dev@ozlabs•org
Subject: Re: help with ppc sections -- no luck, any ideas?
Date: Wed, 08 Aug 2007 10:24:23 -0600 [thread overview]
Message-ID: <46B9EE37.6060600@nortel.com> (raw)
In-Reply-To: <46A8F22E.6010701@nortel.com>
Well, I've played around with the sections a bit more, and just can't
seem to get it to work. As soon as I apply the following, the kernel
refuses to boot. (And if I remove the changes to _GLOBAL, then it
refuses to boot if I enable CONFIG_KPROBES.)
Index: linux/include/asm-ppc/processor.h
===================================================================
--- linux.orig/include/asm-ppc/processor.h 2007-08-02 16:12:16.000000000
-0600
+++ linux/include/asm-ppc/processor.h 2007-08-02 16:26:06.000000000 -0600
@@ -38,9 +38,20 @@
#define _GLOBAL(n)\
.stabs __stringify(n:F-1),N_FUN,0,0,n;\
+ .section ".text"; \
.globl n;\
n:
+#ifdef CONFIG_KPROBES
+#define _KPROBE(n)\
+ .stabs __stringify(n:F-1),N_FUN,0,0,n;\
+ .section ".kprobes.text","a"; \
+ .globl n;\
+n:
+#else
+#define _KPROBE(n) _GLOBAL(n)
+#endif
+
/*
* this is the minimum allowable io space due to the location
* of the io areas on prep (first one at 0x80000000) but
Index: linux/arch/ppc/kernel/misc.S
===================================================================
--- linux.orig/arch/ppc/kernel/misc.S 2007-08-02 16:12:16.000000000 -0600
+++ linux/arch/ppc/kernel/misc.S 2007-08-02 16:24:43.000000000 -0600
@@ -624,7 +624,7 @@
*
* flush_icache_range(unsigned long start, unsigned long stop)
*/
-_GLOBAL(flush_icache_range)
+_KPROBE(flush_icache_range)
BEGIN_FTR_SECTION
blr /* for 601, do nothing */
END_FTR_SECTION_IFCLR(CPU_FTR_SPLIT_ID_CACHE)
Based on Segher's comments I tried changing it to:
+ .section ".text","ax"; \
but that didn't work either.
Anyone else got any suggestions on how I might force
flush_icache_range() into a ".kprobes.text" section?
Chris
prev parent reply other threads:[~2007-08-08 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 19:12 help with ppc sections? Chris Friesen
2007-07-26 19:55 ` Grant Likely
2007-07-27 18:55 ` Chris Friesen
2007-07-31 16:38 ` Segher Boessenkool
2007-08-08 16:24 ` Chris Friesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B9EE37.6060600@nortel.com \
--to=cfriesen@nortel$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox