Subject: Re: [PATCH] qe: miscellaneous code improvements and fixes to the QE library

From: Scott Wood <[email-masked]>
Date: Wed, 19 Sep 2007 13:28:58 -0500

Timur Tabi wrote:
> -void qe_setbrg(u32 brg, u32 rate)
> +void qe_setbrg(unsigned int brg, unsigned int rate, unsigned int multiplier)
>  {
>  	volatile u32 *bp;

While you're at it, this should be __be32 __iomem *, no volatile.

> +/* Configure the UCC to either Slow or Fast.
> + *
> + * A given UCC can be figured to support either "slow" devices (e.g. UART)
> + * or "fast" devices (e.g. Ethernet).
> + *
> + * 'ucc_num' is the UCC number, from 0 - 7.
> + *
> + * This function also sets the UCC_GUEMR_SET_RESERVED3 bit because that bit
> + * must always be set to 1.
> + */
> +int ucc_set_type(unsigned int ucc_num, enum ucc_speed_type speed)
>  {
> -	u8 guemr = 0;
> +	u8 __iomem *p_guemr;

We don't do Hungarian notation in Linux. :-)
What's wrong with just "u8 __iomem *guemr"?

-Scott