public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH 2/2] PowerPC: Fix Sequoia MAL0 and EMAC dts entries.
Date: Thu, 20 Sep 2007 22:55:54 +0400	[thread overview]
Message-ID: <46F2C23A.40001@ru.mvista.com> (raw)
In-Reply-To: <20070920135153.588cfd61@weaponx.rchland.ibm.com>

Josh Boyer wrote:
> On Thu, 20 Sep 2007 22:46:18 +0400
> Valentine Barshak <vbarshak@ru•mvista.com> wrote:
> 
>> Valentine Barshak wrote:
>>> David Gibson wrote:
>>>> On Tue, Sep 18, 2007 at 09:29:13PM +0400, Valentine Barshak wrote:
>>>>> According to PowerPC 440EPx documentation,
>>>>> MAL0 is comprised of four channels (two transmit and two receive).
>>>>> Each channel is dedicated to one of two EMAC cores.
>>>>> This patch fixes Sequoia DTS MAL0 entry and EMAC entries,
>>>>> assigning correct channel numbers to EMACs.
>>>> Hrm.. did they change the EMAC in 440EPx to only use one MAL
>>>> tx-channel?  All the older ones could use two (for no readily apparent
>>>> reason, IMO).
>>>>
>>> Yes, they did.
>>> Just 1 tx and 1 rx-channel per EMAC. Just 2 bits to select channels, 
>>> while all other bits in MAL registers are reserved.
>>> I'm not sure why they did it (possible bus bandwidth problems), but it's 
>>> impossible to set more than 1 rx/tx channel for each EMAC in 440EPx.
>> Josh, David, is this patch OK?
> 
> Yeah.  I applied it to my tree and asked Paul to pull.  Same for the
> Bamboo one.
> 
> josh
OK thanks :)

      reply	other threads:[~2007-09-20 18:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18 17:25 [PATCH 0/2] PowerPC: Fix MAL0 DTS entries for Bamboo and Sequoia Valentine Barshak
2007-09-18 17:27 ` [PATCH 1/2] PowerPC: Fix Bamboo MAL0 dts entry Valentine Barshak
2007-09-18 17:29 ` [PATCH 2/2] PowerPC: Fix Sequoia MAL0 and EMAC dts entries Valentine Barshak
2007-09-19  1:05   ` David Gibson
2007-09-19 11:14     ` Valentine Barshak
2007-09-20 18:46       ` Valentine Barshak
2007-09-20 18:51         ` Josh Boyer
2007-09-20 18:55           ` Valentine Barshak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F2C23A.40001@ru.mvista.com \
    --to=vbarshak@ru$(echo .)mvista.com \
    --cc=david@gibson$(echo .)dropbear.id.au \
    --cc=jwboyer@linux$(echo .)vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox