From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Olof Johansson <olof@lixom•net>,
Josh Boyer <jwboyer@gmail•com>, Stefan Roese <sr@denx•de>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: Sequoia kernel crash workaround.
Date: Mon, 24 Sep 2007 14:35:49 +0400 [thread overview]
Message-ID: <46F79305.9050300@ru.mvista.com> (raw)
In-Reply-To: <1190535664.3723.16.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Thu, 2007-09-20 at 12:29 -0500, Josh Boyer wrote:
>> On Thu, 20 Sep 2007 12:25:06 -0500
>> Olof Johansson <olof@lixom•net> wrote:
>>
>>> On Thu, Sep 20, 2007 at 08:56:32PM +0400, Valentine Barshak wrote:
>>>> I was thinking about it. Looks like it's the best place, but the code that
>>>> actually calls setup_cpu is under ifdef CONFIG_PPC64, while lots of
>>>> cpu_setup functions are defined for ppc32 processors.
>>>> Is it OK to remove this ifdef, or should I do CONFIG_PPC64 || CONFIG_44x?
>>> Sounds like something that went wrong at the merge of ppc and ppc64.
>>>
>>> Take out the ifdef, even if there's fallout we should deal with it
>>> instead of adding more complex ifdefs.
>> Yeah. Looks like BenH did this in commit:
>>
>> 42c4aaadb737e0e672b3fb86b2c41ff59f0fb8bc
>>
>> Ben, any reason you ifdef'd it for ppc64?
>
> I'll have to check on monday what's up there, but isn't setup_cpu called
> from a different place on 32 bits? There are some subtle difference with
> the way the cpu feature stuff is initialized /done between 32 and 64
> bits that we haven't fully reconciled yet.
>
> Ben.
>
From what I've seen, setup_cpu is never called for BOOKE.
Currently It's called from cputable.c for PPC64 and from head_32.S for 6xx.
Thanks,
Valentine.
>
next prev parent reply other threads:[~2007-09-24 10:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 18:39 Sequoia kernel crash workaround Valentine Barshak
2007-09-19 19:12 ` Josh Boyer
2007-09-19 19:19 ` Stefan Roese
2007-09-19 19:30 ` Olof Johansson
2007-09-19 20:08 ` Josh Boyer
2007-09-20 16:56 ` Valentine Barshak
2007-09-20 17:25 ` Olof Johansson
2007-09-20 17:29 ` Josh Boyer
2007-09-23 8:21 ` Benjamin Herrenschmidt
2007-09-24 10:35 ` Valentine Barshak [this message]
2007-09-24 20:55 ` Benjamin Herrenschmidt
2007-09-24 21:01 ` Josh Boyer
2007-09-20 18:03 ` Olof Johansson
2007-09-20 17:32 ` Milton Miller
2007-09-20 17:55 ` [PATCH] PowerPC: add setup_cpu for 44x for processor-specific init Valentine Barshak
2007-09-20 18:13 ` Josh Boyer
2007-09-20 18:15 ` Valentine Barshak
2007-09-20 18:54 ` Kumar Gala
2007-09-20 18:55 ` Valentine Barshak
2007-09-21 1:34 ` Paul Mackerras
2007-09-20 18:02 ` Sequoia kernel crash workaround Josh Boyer
2007-09-20 18:13 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F79305.9050300@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=jwboyer@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=sr@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox