From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH v3] Make instruction dumping work in real mode.
Date: Thu, 27 Sep 2007 22:09:26 +0400 [thread overview]
Message-ID: <46FBF1D6.7010400@ru.mvista.com> (raw)
In-Reply-To: <20070927180001.GA18185@loki.buserror.net>
Hello.
Scott Wood wrote:
> On non-book-E-or-4xx, exceptions execute in real mode. If a fault happens
> that leads to a register dump, the kernel currently prints XXXXXXXX because
> it doesn't realize that PC is a physical address.
> This patch checks the state of the IMMU, and if necessary converts PC into a
> virtual address.
>
> Signed-off-by: Scott Wood <scottwood@freescale•com>
> ---
> Resent with 40x->44x.
>
> arch/powerpc/kernel/process.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 57c589c..6dbde7f 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -354,6 +354,14 @@ static void show_instructions(struct pt_regs *regs)
> if (!(i % 8))
> printk("\n");
>
> +#if !defined(CONFIG_BOOKE) && !defined(CONFIG_44x)
Doesn't CONFIG_44x select CONFIG_BOOKE? Maybe you meant CONFIG_40x?
> + /* If executing with the IMMU off, adjust pc rather
> + * than print XXXXXXXX.
> + */
> + if (!(regs->msr & MSR_IR))
> + pc = (unsigned long)phys_to_virt(pc);
> +#endif
> +
> /* We use __get_user here *only* to avoid an OOPS on a
> * bad address because the pc *should* only be a
> * kernel address.
WBR, Sergei
next prev parent reply other threads:[~2007-09-27 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 18:00 [PATCH v3] Make instruction dumping work in real mode Scott Wood
2007-09-27 18:02 ` Kumar Gala
2007-09-27 18:09 ` Sergei Shtylyov [this message]
2007-09-27 18:23 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FBF1D6.7010400@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox