From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>, linuxppc-dev@lists•ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs•ru>,
kvm-ppc@vger•kernel.org,
Jose Ricardo Ziviani <joserz@linux•ibm.com>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH kernel] KVM: PPC: Fix incorrect guest-to-user-translation error handling
Date: Mon, 2 Sep 2019 13:06:14 +1000 (AEST) [thread overview]
Message-ID: <46MFN66pq4z9sNf@ozlabs.org> (raw)
In-Reply-To: <20190826045520.92153-1-aik@ozlabs.ru>
On Mon, 2019-08-26 at 04:55:20 UTC, Alexey Kardashevskiy wrote:
> H_PUT_TCE_INDIRECT handlers receive a page with up to 512 TCEs from
> a guest. Although we verify correctness of TCEs before we do anything
> with the existing tables, there is a small window when a check in
> kvmppc_tce_validate might pass and right after that the guest alters
> the page with TCEs which can cause early exit from the handler and
> leave srcu_read_lock(&vcpu->kvm->srcu) (virtual mode) or lock_rmap(rmap)
> (real mode) locked.
>
> This fixes the bug by jumping to the common exit code with an appropriate
> unlock.
>
> Fixes: 121f80ba68f1 ("KVM: PPC: VFIO: Add in-kernel acceleration for VFIO")
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs•ru>
Applied to powerpc topic/ppc-kvm, thanks.
https://git.kernel.org/powerpc/c/4f916593be9da38c5cf0d3a5c386b57beb70f422
cheers
prev parent reply other threads:[~2019-09-02 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 4:55 [PATCH kernel] KVM: PPC: Fix incorrect guest-to-user-translation error handling Alexey Kardashevskiy
2019-09-02 3:06 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46MFN66pq4z9sNf@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=joserz@linux$(echo .)ibm.com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox