From: Scott Wood <scottwood@freescale•com>
To: Gerhard Pircher <gerhard_pircher@gmx•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: Problem with OF interrupt parsing code
Date: Mon, 01 Oct 2007 16:37:56 -0500 [thread overview]
Message-ID: <470168B4.7090005@freescale.com> (raw)
In-Reply-To: <470165F6.7030505@freescale.com>
Scott Wood wrote:
>> The problem occurs now, if there is no device node defined for another
>> PCI device. In this case, of_irq_map_pci() checks for an interrupt pin,
>> searches again for the host bridge node and calls of_irq_map_raw() with
>> the device node of the host bridge. The function finds the
>> #interrupt-cells, #address-cells, interrupt-controller properties, but
>> fails to find the interrupt-map property (because it's missing in the
>> device tree). Therefore the function then tries to find a new parent,
>> which leads to an endless loop (it always selects the PCI2ISA southbridge
>> in the device tree).
>
> That seems likely... there should probably be some loop detection.
Actually, it doesn't -- it should stop when it sees the
interrupt-controller property in the i8259 node, at which point it'll be
trying to use the raw PCI IRQ pin number as an i8259 IRQ. This is
Unlikely To Work(tm).
-Scott
next prev parent reply other threads:[~2007-10-01 21:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 21:00 Problem with OF interrupt parsing code Gerhard Pircher
2007-10-01 21:11 ` Gerhard Pircher
2007-10-01 21:39 ` Benjamin Herrenschmidt
2007-10-01 22:33 ` Segher Boessenkool
2007-10-01 22:54 ` Benjamin Herrenschmidt
2007-10-01 22:55 ` Benjamin Herrenschmidt
2007-10-01 23:36 ` Segher Boessenkool
2007-10-02 12:38 ` Gerhard Pircher
2007-10-02 22:03 ` Benjamin Herrenschmidt
2007-10-03 7:43 ` Gerhard Pircher
2007-10-01 21:26 ` Scott Wood
2007-10-01 21:37 ` Scott Wood [this message]
2007-10-01 21:43 ` Benjamin Herrenschmidt
2007-10-01 21:48 ` Scott Wood
2007-10-01 22:07 ` Benjamin Herrenschmidt
2007-10-02 12:46 ` Gerhard Pircher
2007-10-01 21:36 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-10-02 12:40 Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470168B4.7090005@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=gerhard_pircher@gmx$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox