Subject: Re: [linux-usb-devel] [PATCH] OHCI: add PowerPC 440EP/440EPx support

From: Valentine Barshak <[email-masked]>
Date: Mon, 08 Oct 2007 20:06:58 +0400

David Brownell wrote:
>> @@ -612,7 +612,7 @@ static inline u32 hc32_to_cpup (const st
>>   * to arch/powerpc
>>   */
>>  
>> -#ifdef CONFIG_STB03xxx
>> +#if defined(CONFIG_STB03xxx) || defined(CONFIG_440EP) || defined(CONFIG_440EPX)
>>  #define OHCI_BE_FRAME_NO_SHIFT	16
>>  #else
>>  #define OHCI_BE_FRAME_NO_SHIFT	0
> 
> Near as I can tell, the original code is wrong ... the hcca->frame_no
> byte offset is fully specified, so that shift should always be 16.
> 
> - Dave
> 
Are you saying that it should always be #define OHCI_BE_FRAME_NO_SHIFT 
16 for big endian platforms?