From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Ranulf Doswell <ralf@ranulf•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [patch 2/6] PS3: Remove unused os-area params
Date: Mon, 08 Oct 2007 10:53:32 -0700 [thread overview]
Message-ID: <470A6E9C.50904@am.sony.com> (raw)
In-Reply-To: <18a15270710080700m514b49f6p7dc9cf6c8f80d6a6@mail.gmail.com>
Ranulf Doswell wrote:
> On 06/10/2007, *geoffrey.levand@am•sony.com
> <mailto:geoffrey.levand@am•sony.com>* <geoffrey.levand@am•sony.com
> <mailto:geoffrey.levand@am•sony.com>> wrote:
>
>> struct saved_params {
>>- /* param 0 */
>> s64 rtc_diff;
>> unsigned int av_multi_out;
>>- unsigned int ctrl_button;
>>- /* param 1 */
>>- u8 static_ip_addr[4];
>>- u8 network_mask[4];
>
>>- u8 default_gateway[4];
>>- /* param 2 */
>>- u8 dns_primary[4];
>>- u8 dns_secondary[4];
>> } static saved_params;
>
> As these values are correctly populated by the hypervisor from the
> preferences on the standard PS3 OS, it is incredibly useful to have this
> information available.
No, it is not used, and I never used it.
> Whilst none of the current 'popular' distributions use these fields, I
> am currently in the process of making a bootable CD image that does use
> them in order to initialise the network. Not having this information
> available means that the only sensible option is to use DHCP, which may
> well not be available in every case.
>
> Please can we have these fields back? They don't actually take up all
> that much room, yet they are incredibly useful.
As a general rule we don't put unused code into the kernel, and I have no
plan to provide the support you mention. Please submit a patch to the ML
with your feature for review.
-Geoff
next prev parent reply other threads:[~2007-10-08 17:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 21:35 [patch 0/6] PS3 os area patches for 2.6.24 geoffrey.levand
2007-10-06 21:35 ` [patch 1/6] PS3: Cleanup of os-area.c geoffrey.levand
2007-10-06 21:35 ` [patch 2/6] PS3: Remove unused os-area params geoffrey.levand
2007-10-08 14:00 ` Ranulf Doswell
2007-10-08 17:53 ` Geoff Levand [this message]
2007-10-08 22:38 ` Ranulf Doswell
2007-10-08 22:50 ` Geoff Levand
2007-10-06 21:35 ` [patch 3/6] PS3: os-area workqueue processing geoffrey.levand
2007-10-06 21:35 ` [patch 4/6] PS3: Add os-area rtc_diff set/get routines geoffrey.levand
2007-10-06 21:35 ` [patch 5/6] PS3: Save os-area params to device tree geoffrey.levand
2007-10-06 21:35 ` [patch 6/6] PS3: Add os-area database routines geoffrey.levand
2007-10-08 8:27 ` Geert Uytterhoeven
2007-10-09 1:08 ` Geoff Levand
2007-10-08 12:16 ` Geert Uytterhoeven
2007-10-09 1:12 ` Geoff Levand
2007-10-08 13:48 ` Ranulf Doswell
2007-10-08 17:52 ` Geoff Levand
2007-10-08 22:59 ` Ranulf Doswell
2007-10-08 23:36 ` Geoff Levand
2007-10-09 9:35 ` Geert Uytterhoeven
2007-10-09 12:23 ` Ranulf Doswell
2007-10-09 1:07 ` [patch v2] " Geoff Levand
2007-10-09 11:38 ` Geert Uytterhoeven
2007-10-09 17:15 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470A6E9C.50904@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=ralf@ranulf$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox