From: Matt Sealey <matt@genesi-usa•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org, domen.puncer@telargo•com
Subject: Re: [PATCH v2 4/7] bestcomm: core bestcomm support for Freescale MPC5200
Date: Mon, 15 Oct 2007 12:55:07 +0100 [thread overview]
Message-ID: <4713551B.9040103@genesi-usa.com> (raw)
In-Reply-To: <20071014044205.23438.36036.stgit@trillian.cg.shawcable.net>
My nits:
Grant Likely wrote:
> From: Sylvain Munaut <tnt@246tNt•com>
> +static int __devinit
> +bcom_engine_init(void)
Why "bcom" and not "bestcomm"?
> + /* Disable COMM Bus Prefetch, apparently it's not reliable yet */
> + /* FIXME: This should be done on 5200 and not 5200B ... */
> + out_be16(&bcom_eng->regs->PtdCntrl, in_be16(&bcom_eng->regs->PtdCntrl) | 1);
This really, really shouldn't even be here, could it be moved to a platform
init, or switched on a PVR/SVR here?
> +int bcom_sram_init(struct device_node *sram_node, char *owner)
> +{
> + int rv;
> + const u32 *regaddr_p;
> + u64 regaddr64, size64;
> + unsigned int psize;
> +
> + /* Create our state struct */
> + if (bcom_sram) {
> + printk(KERN_ERR "%s: bcom_sram_init: "
> + "Already initialiwed !\n", owner);
> + return -EBUSY;
> + }
initialised or initialized :)
> + printk(KERN_ERR "%s: bcom_sram_init: "
> + "Couln't request region !\n", owner);
> + rv = -EBUSY;
> + goto error_free;
Couldn't or could not.
--
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations
next prev parent reply other threads:[~2007-10-15 11:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 4:41 [PATCH v2 0/7] 2nd respin of bestcomm patches Grant Likely
2007-10-14 4:41 ` [PATCH v2 1/7] exports rheap symbol to modules Grant Likely
2007-10-14 4:41 ` [PATCH v2 2/7] rheap: Changes config mechanism Grant Likely
2007-10-15 13:43 ` Kumar Gala
2007-10-15 13:55 ` Grant Likely
2007-10-15 14:03 ` Kumar Gala
2007-10-15 14:06 ` Grant Likely
2007-10-15 14:53 ` Timur Tabi
2007-10-15 14:54 ` Kumar Gala
2007-10-15 14:54 ` Timur Tabi
2007-10-15 15:09 ` Grant Likely
2007-10-14 4:42 ` [PATCH v2 3/7] mpc52xx: Update mpc52xx_psc structure with B revision changes Grant Likely
2007-10-14 4:42 ` [PATCH v2 4/7] bestcomm: core bestcomm support for Freescale MPC5200 Grant Likely
2007-10-14 11:33 ` Sven Luther
2007-10-14 20:22 ` Grant Likely
2007-10-14 20:25 ` Sven Luther
2007-10-14 21:23 ` Grant Likely
2007-10-15 6:12 ` Sven Luther
2007-10-15 11:55 ` Matt Sealey [this message]
2007-10-15 14:04 ` Grant Likely
2007-10-15 20:53 ` Matt Sealey
2007-10-15 20:55 ` Matt Sealey
2007-10-15 21:06 ` Grant Likely
2007-10-16 13:21 ` tnt
2007-10-15 14:06 ` Kumar Gala
2007-10-15 14:20 ` Grant Likely
2007-10-15 14:39 ` Matt Sealey
2007-10-14 4:42 ` [PATCH v2 5/7] bestcomm: ATA task support Grant Likely
2007-10-14 4:42 ` [PATCH v2 6/7] bestcomm: FEC " Grant Likely
2007-10-14 4:42 ` [PATCH v2 7/7] bestcomm: GenBD " Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713551B.9040103@genesi-usa.com \
--to=matt@genesi-usa$(echo .)com \
--cc=domen.puncer@telargo$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox