Subject: Re: [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 15 Oct 2007 19:42:12 +0400

Anton Vorontsov wrote:

> This patch creates localbus node, moves bcsr into it, and adds
> localbus to the probe path.

> Signed-off-by: Anton Vorontsov <[email-masked]>

> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
> index 5439437..296adc3 100644
> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> @@ -42,9 +42,17 @@
>  		reg = <00000000 10000000>;
>  	};
>  
> -	bcsr@f8000000 {
> -		device_type = "board-control";
> -		reg = <f8000000 8000>;
> +	localbus@f0000000 {
> +		compatible = "fsl,mpc8568mds-localbus";

    Is the entity described as "localbus" indeed so *board* specific?

> +		#address-cells = <2>;
> +		#size-cells = <1>;
> +		reg = <f0000000 10000000>;
> +		ranges = <0 0 f8000000 0008000>;

    Isn't that range a part of "reg"?

> +
> +		bcsr@0,0 {
> +			device_type = "board-control";
> +			reg = <0 0 8000>;
> +		};
>  	};
>  
>  	soc8568@e0000000 {

WBR, Sergei