From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Anton Vorontsov <avorontsov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash
Date: Mon, 15 Oct 2007 21:33:40 +0400 [thread overview]
Message-ID: <4713A474.1000301@ru.mvista.com> (raw)
In-Reply-To: <20071015161631.GB30512@localhost.localdomain>
Anton Vorontsov wrote:
> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
> Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
> index 8e15dba..1198363 100644
> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> @@ -47,12 +47,45 @@
> #address-cells = <2>;
> #size-cells = <1>;
> reg = <e0005000 d8>;
> - ranges = <1 0 f8000000 0008000>;
> + ranges = <1 0 f8000000 0008000
> + 0 0 fe000000 2000000>;
>
> bcsr@1,0 {
> device_type = "board-control";
> reg = <1 0 8000>;
> };
> +
> + flash@0,0 {
> + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
> + reg = <0 0 2000000>;
> + probe-type = "CFI";
I don't get it -- has physmap_of.c rewrite been already committed?
If yes, you don't need probe_type; if no, your "compatible" won't work...
Well, I see that the driver rewrite has been committed (when I wasn't looking
8-)...
> + bank-width = <2>;
> + device-width = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + hrcw@0 {
> + label = "hrcw";
> + reg = <0 20001>;
What?! Odd sized partition? Don't try to follow both the old and new
partition device tree specs -- you'll only get yourself into trouble with
this. The size-cell doesn't bear r/o flag in the new paritions spec.
> + read-only;
> + };
> +
> + kernel@20000 {
> + label = "kernel";
> + reg = <20000 200000>;
> + };
> +
> + rootfs@220000 {
> + label = "rootfs";
> + reg = <220000 1d60000>;
> + };
> +
> + uboot@1f80000 {
> + label = "u-boot";
> + reg = <1f80000 80000>;
> + read-only;
Well, this is not even consistent... :-)
> + };
> + };
> };
WBR, Sergei
next prev parent reply other threads:[~2007-10-15 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 15:35 [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Anton Vorontsov
2007-10-15 15:42 ` Sergei Shtylyov
2007-10-15 15:57 ` Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 " Anton Vorontsov
2007-10-15 16:16 ` [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash Anton Vorontsov
2007-10-15 17:33 ` Sergei Shtylyov [this message]
2007-10-15 18:00 ` Kumar Gala
2007-10-16 1:12 ` David Gibson
2007-10-16 10:55 ` Anton Vorontsov
2007-10-15 18:47 ` [PATCH 1/2] [RFC][POWERPC] MPC8568E-MDS: create localbus node Scott Wood
2007-10-15 19:08 ` Kumar Gala
2007-10-15 19:10 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713A474.1000301@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox