From: Jeff Garzik <jeff@garzik•org>
To: Joachim Fenkes <fenkes@de•ibm.com>
Cc: Thomas Q Klein <tklein@de•ibm.com>,
Jan-Bernd Themann <THEMANN@de•ibm.com>,
netdev@vger•kernel.org, Paul Mackerras <pmac@au1•ibm.com>,
LKML <linux-kernel@vger•kernel.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs•org>,
Christoph Raisch <raisch@de•ibm.com>,
Marcus Eder <meder@de•ibm.com>, Paul Mackerras <paulus@samba•org>,
Stefan Roscher <stefan.roscher@de•ibm.com>
Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
Date: Tue, 16 Oct 2007 11:00:26 -0400 [thread overview]
Message-ID: <4714D20A.3080607@garzik.org> (raw)
In-Reply-To: <200710162320.00630.fenkes@de.ibm.com>
Joachim Fenkes wrote:
> On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote:
>> Roland Dreier <rdreier@cisco•com> wrote on 03.10.2007 20:05:44:
>>> > > Replace struct ibmebus_dev and struct ibmebus_driver with struct
> of_device
>>> > > and struct of_platform_driver, respectively. Match the external
> ibmebus
>>> > > interface and drivers using it.
>>> > >
>>> > > Signed-off-by: Joachim Fenkes <fenkes@de•ibm.com>
>>> >
>>> > This is somewhat difficult as this patch touches files that are the
>>> > responsibility of three different maintainers. �Is it possible to
>>> > split the patch into three, one for each maintainer (possibly by
>>> > keeping both old and new interfaces around for a little while)?
>>> >
>>> > If not, then you need to get an Acked-by and an agreement that this
>>> > change can go via the powerpc.git tree from Roland Dreier and Jeff
>>> > Garzik.
>>>
>>> I don't see anything objectionable in the infiniband parts of the
>>> patch -- I don't have any way to test the changes but it all looks
>>> like a straightforward conversion to a new platform API. So:
>>>
>>> Acked-by: Roland Dreier <rolandd@cisco•com>
>>>
>>> - R.
>> Looks good from eHEA driver perspective.
>>
>> Acked-by: Jan-Bernd Themann <themann@de•ibm.com>
>
> Jeff, do you have any objections against this patch going into the kernel
> via Paul's powerpc.git tree? It touches only a few lines of ehea which are
> specific to the bus interface changes.
>
> You can see the full patch here:
> http://patchwork.ozlabs.org/linuxppc/patch?id=13750
>
> If you have no objections, please ack the patch so Paul can include it.
Fine with me...
Jeff
next prev parent reply other threads:[~2007-10-16 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF48E0997F.B61F7220-ONC125736F.002D7F06-C125736F.002DD39C@de.ibm.com>
2007-10-16 21:20 ` [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers Joachim Fenkes
2007-10-16 15:00 ` Jeff Garzik [this message]
2007-10-16 15:27 ` Stephen Rothwell
2007-10-17 15:21 ` Joachim Fenkes
2007-09-26 9:43 [PATCH 0/5] [REPOST] PowerPC: ibmebus refactoring and fixes Joachim Fenkes
2007-09-26 9:45 ` [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers Joachim Fenkes
2007-09-27 11:31 ` Arnd Bergmann
2007-10-03 2:51 ` Paul Mackerras
2007-10-03 18:05 ` Roland Dreier
2007-10-09 8:21 ` Jan-Bernd Themann
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 12:10 [PATCH 0/5] PowerPC: ibmebus refactoring and fixes Joachim Fenkes
2007-09-25 12:12 ` [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers Joachim Fenkes
2007-09-25 14:42 ` Arnd Bergmann
2007-09-26 8:43 ` Joachim Fenkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4714D20A.3080607@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=THEMANN@de$(echo .)ibm.com \
--cc=fenkes@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=meder@de$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=pmac@au1$(echo .)ibm.com \
--cc=raisch@de$(echo .)ibm.com \
--cc=stefan.roscher@de$(echo .)ibm.com \
--cc=tklein@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox