Subject: Re: [POWERPC 03/15] [POWERPC] TQM5200 board support

From: Scott Wood <[email-masked]>
Date: Wed, 17 Oct 2007 10:33:55 -0500

Marian Balakowicz wrote:
> Scott Wood wrote:
>>> +void tqm5200_show_cpuinfo(struct seq_file *m)
>>> +{
>>> +	struct device_node* np = of_find_all_nodes(NULL);
>>> +	const char *model = NULL;
>>> +
>>> +	if (np)
>>> +		model = of_get_property(np, "model", NULL);
>>> +
>>> +	seq_printf(m, "vendor\t\t:	Freescale Semiconductor\n");
>>> +	seq_printf(m, "machine\t\t:	%s\n", model ? model : "unknown");
>>> +
>>> +	of_node_put(np);
>>> +}
>> Get rid of this.
> 
> Agree, that may be overhead in some cases. But there would be also
> cases where printing out a machine name would be informative. CM5200
> is one such example, there are several variants of the hw and platform
> name is too generic.

Maybe, though if we're going to do that it'd be better to just print 
/model in the generic cpuinfo (or somewhere else generic).  And there's 
always /proc/device-tree/model...

-Scott