Subject: Re: [PATCH 07/15] [POWERPC] Promess Motion-PRO DTS

From: Wolfgang Grandegger <[email-masked]>
Date: Thu, 18 Oct 2007 14:50:11 +0200

Hello,

I see one more issue.

Marian Balakowicz wrote:
> Add device tree source file for Motion-PRO board.
> 
> Signed-off-by: Marian Balakowicz <[email-masked]>
> ---
[deletions]
> +		gpio@b00 {
> +			compatible = "mpc5200b-gpio\0mpc5200-gpio";
> +			reg = <b00 40>;
> +			interrupts = <1 7 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +		};

Do we not need the field "device_type = "gpio" here?

> +		gpio-wkup@c00 {
> +			compatible = "mpc5200b-gpio-wkup\0mpc5200-gpio-wkup";
> +			reg = <c00 40>;
> +			interrupts = <1 8 0 0 3 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +		};

And the same here.

Wolfgang.