From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Paul Mackerras <paulus@samba•org>
Cc: linuxppc-dev@ozlabs•org, Thomas Gleixner <tglx@linutronix•de>,
Realtime Kernel <linux-rt-users@vger•kernel.org>
Subject: Re: [PATCH v2 3/4] Implement clockevents driver for powerpc
Date: Fri, 19 Oct 2007 16:11:31 +0400 [thread overview]
Message-ID: <47189EF3.7010103@ru.mvista.com> (raw)
In-Reply-To: <18200.3600.459275.823335@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Sergei Shtylyov writes:
>> And now you have incomplete read_persistent_clock() implementation for
> I don't see anything incomplete about it. If you do, feel free to
> post a patch.
The xtime_lock is still grabbed by time_init()
>>example, god knows why it was preferred to mine -- well, it also implemented
> Your most recent post of your patch to implement read_persistent_clock
> was in May -- five months ago -- and you said this about it: "This
Right, the most recent was in May but that was only a recast of the
October version (i.e. year old) -- that patch got somehow dropped from later
the -rt patches IIRC.
> patch hasn't received a good testing though".
Right, it never has been tested on macines with RTC. That was a fair
warning. :-)
> You don't have to be a god to figure out why I preferred a patch that
> had been tested, where the author was responding to comments and
> posting updated versions of his patch in the period leading up to the
> merge window, over that.
Unfortunately, I didn't have time to try pusing it into every -rc1 since
2.6.18 -- there has been experimental hrtimers patchset at that time with even
x86 stuff being unmerged to mainline, so the stuff could only be pushed into
that patchset last autumn. I was going to try addressing vDSO stuff, yet there
has been too much work aside of that. Still, I've answered the mails. :-)
>> I just wanted the reasons clarified and got what I wanted -- as I thought,
>>the decision behind preferring patches was somewhat biased, nobody really
>>cared about code quality or just wasn't familiar with hrtimers enough to judge
>>on the code quality...
> You really know how to persuade people to cooperate, don't you... :P
Well, I'm not persuading anybody, sine I don't believe that I can persuade
somebody to do my work, so had to just vainly complain :-).
However, I agree that my complaints/ comments might have been somewhat
rash and unjust -- Tony's patches are *not* that bad after all. :-)
The only thing I'm still unusre about is that deterministic accounting.
Could you point me at the patch which deals with this (at least for System 390
:-)?
> Paul.
WBR, Sergei
next prev parent reply other threads:[~2007-10-19 12:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 3:26 [PATCH v2 1/4] Implement {read,update}_persistent_clock Tony Breeds
2007-09-21 3:26 ` [PATCH v2 2/4] Implement generic time of day clocksource for powerpc machines Tony Breeds
2007-09-21 4:05 ` Daniel Walker
2007-09-21 4:59 ` Paul Mackerras
2007-09-21 6:43 ` David Gibson
2007-09-21 4:52 ` Stephen Rothwell
2007-09-21 21:35 ` Tony Breeds
2007-09-21 21:35 ` [PATCH v3 " Tony Breeds
2007-10-03 0:48 ` Paul Mackerras
2007-10-03 4:00 ` Thomas Gleixner
2007-09-21 3:26 ` [PATCH v2 4/4] Enable tickless idle and high res timers for powerpc Tony Breeds
2007-09-21 3:26 ` [PATCH v2 3/4] Implement clockevents driver " Tony Breeds
2007-10-15 17:40 ` Sergei Shtylyov
2007-10-15 18:33 ` Sergei Shtylyov
2007-10-15 23:44 ` Paul Mackerras
2007-10-17 14:29 ` Sergei Shtylyov
2007-10-18 0:51 ` Paul Mackerras
2007-10-18 15:11 ` Sergei Shtylyov
2007-10-19 1:53 ` Paul Mackerras
2007-10-19 12:11 ` Sergei Shtylyov [this message]
2007-10-19 12:36 ` Paul Mackerras
2007-10-19 13:35 ` Sergei Shtylyov
2007-10-24 12:07 ` Sergei Shtylyov
2007-10-24 23:55 ` Paul Mackerras
2007-10-17 14:34 ` Sergei Shtylyov
2007-10-18 0:36 ` Paul Mackerras
2007-10-18 14:48 ` Sergei Shtylyov
2007-10-19 0:14 ` Paul Mackerras
2007-10-19 9:22 ` Gabriel Paubert
2007-10-19 11:22 ` Paul Mackerras
2007-10-19 11:49 ` Sergei Shtylyov
2007-10-19 12:24 ` Paul Mackerras
2007-09-26 19:04 ` [PATCH v2 1/4] Implement {read,update}_persistent_clock Steven Rostedt
2007-09-26 19:39 ` Sergei Shtylyov
2007-09-26 19:44 ` Steven Rostedt
2007-09-26 19:58 ` Thomas Gleixner
2007-10-15 18:05 ` Sergei Shtylyov
2007-10-15 23:46 ` Paul Mackerras
2007-10-16 1:19 ` Benjamin Herrenschmidt
2007-10-17 12:45 ` Sergei Shtylyov
2007-09-27 1:59 ` Benjamin Herrenschmidt
2007-10-15 18:07 ` Sergei Shtylyov
2007-10-15 23:02 ` Benjamin Herrenschmidt
2007-10-17 15:34 ` Sergei Shtylyov
2007-10-18 14:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47189EF3.7010103@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=linux-rt-users@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox