public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Valentine Barshak <vbarshak@ru•mvista.com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, linux-usb-devel@lists•sourceforge.net
Subject: Re: [PATCH] PowerPC 440EPx Sequoia USB OHCI DTS entry
Date: Tue, 23 Oct 2007 21:18:18 +0400	[thread overview]
Message-ID: <471E2CDA.1080301@ru.mvista.com> (raw)
In-Reply-To: <e1b19c12c7006e763a56627fa9a05ec9@kernel.crashing.org>

Segher Boessenkool wrote:
>> +            compatible = "ohci-be";
> 
> Can we fix this please, in the same way as with EHCI?  I.e., the
> "compatible" should say it is USB, e.g. "usb-ohci"; and the
> "big-endian" quirkiness should be expressed by a property, not by
> the "compatible" name (since that would lead to exponential
> explosion of all possible combinations of quirks, if nothing else).
> 
> 
> Segher
> 
I was thinking about it too.
We need to fix the OHCI OF driver and all its users' dts files (if any).
Actually I also don't see much reason for the 
USB_OHCI_HCD_PPC_OF_BE/USB_OHCI_HCD_PPC_OF_LE stuff.
Is this really needed?
Thanks,
Valentine.

  reply	other threads:[~2007-10-23 17:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 14:26 [PATCH] PowerPC 440EPx Sequoia USB OHCI DTS entry Valentine Barshak
2007-10-23 15:33 ` Josh Boyer
2007-10-23 15:35   ` Valentine Barshak
2007-10-23 15:50     ` Josh Boyer
2007-10-23 17:03 ` Segher Boessenkool
2007-10-23 17:18   ` Valentine Barshak [this message]
2007-10-23 21:40     ` Dale Farnsworth
2007-10-24 11:19       ` Valentine Barshak
2007-10-24 12:08         ` Dale Farnsworth
2007-10-24 13:44           ` Valentine Barshak
2007-10-24 14:10             ` Dale Farnsworth
2007-10-24 14:23               ` Valentine Barshak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471E2CDA.1080301@ru.mvista.com \
    --to=vbarshak@ru$(echo .)mvista.com \
    --cc=linux-usb-devel@lists$(echo .)sourceforge.net \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=segher@kernel$(echo .)crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox