public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Marian Balakowicz <m8@semihalf•com>
To: Olof Johansson <olof@lixom•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 02/11] [POWERPC] Add 'lpb' bus type for MPC5200	LocalPlus Bus
Date: Thu, 25 Oct 2007 16:55:35 +0200	[thread overview]
Message-ID: <4720AE67.3060902@semihalf.com> (raw)
In-Reply-To: <20071024000941.GA10926@lixom.net>

Olof Johansson wrote:
> 
> On Wed, Oct 24, 2007 at 01:13:15AM +0200, Marian Balakowicz wrote:
>> Signed-off-by: Marian Balakowicz <m8@semihalf•com>
>> ---
> 
> Your patch lacks any kind of description beyond the title. (I know, it's a
> real simple patch, but a real simple description would do too :)

All right, will add one.

> 
>> --- a/arch/powerpc/kernel/of_platform.c
>> +++ b/arch/powerpc/kernel/of_platform.c
>> @@ -49,6 +49,7 @@ static struct of_device_id of_default_bus_ids[] = {
>>  	{ .type = "plb4", },
>>  	{ .type = "opb", },
>>  	{ .type = "ebc", },
>> +	{ .type = "lpb", },
> 
> I thought it was consensus to keep the new bus ids only in platform
> code and not add them to the default list, and just pass that list in
> to of_platform_bus_probe().

Sounds reasonable, will move it to the 5xxx platform code.

Cheers,
m.

  reply	other threads:[~2007-10-25 14:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 23:13 [PATCH 00/11] [POWERPC] Add TQM5200/CM5200/Motion-PRO board support Marian Balakowicz
2007-10-23 23:13 ` [PATCH 01/11] [POWERPC] Add 'machine: ...' line to common show_cpuinfo() Marian Balakowicz
2007-10-23 23:23   ` David Gibson
2007-10-25 14:17     ` Marian Balakowicz
2007-10-23 23:59   ` Olof Johansson
2007-10-24  7:11   ` Stephen Rothwell
2007-10-25  4:33     ` Milton Miller
2007-10-25 14:47       ` Marian Balakowicz
2007-10-23 23:13 ` [PATCH 02/11] [POWERPC] Add 'lpb' bus type for MPC5200 LocalPlus Bus Marian Balakowicz
2007-10-24  0:09   ` Olof Johansson
2007-10-25 14:55     ` Marian Balakowicz [this message]
2007-10-23 23:13 ` [PATCH 03/11] [POWERPC] Add common mpc52xx_setup_pci() routine Marian Balakowicz
2007-10-24  7:16   ` Stephen Rothwell
2007-10-23 23:13 ` [PATCH 04/11] [POWERPC] Add generic support for MPC5200 based boards Marian Balakowicz
2007-10-24 14:03   ` Grant Likely
2007-10-23 23:13 ` [PATCH 05/11] [POWERPC] TQM5200 DTS Marian Balakowicz
2007-10-24  1:51   ` David Gibson
2007-10-24 14:09     ` Grant Likely
2007-10-25 15:23     ` Marian Balakowicz
2007-10-25  9:57   ` Martin Krause
2007-10-25 13:53     ` Grant Likely
2007-10-25 15:46       ` Marian Balakowicz
2007-10-26  1:33         ` David Gibson
2007-10-29 14:18           ` Marian Balakowicz
2007-10-29 15:40             ` Grant Likely
2007-10-30  0:58               ` David Gibson
2007-10-30  5:58                 ` Grant Likely
2007-10-30 15:34               ` Marian Balakowicz
2007-10-23 23:13 ` [PATCH 06/11] [POWERPC] TQM5200 defconfig Marian Balakowicz
2007-10-23 23:13 ` [PATCH 07/11] [POWERPC] CM5200 DTS Marian Balakowicz
2007-10-23 23:13 ` [PATCH 08/11] [POWERPC] CM5200 defconfig Marian Balakowicz
2007-10-23 23:13 ` [PATCH 09/11] [POWERPC] Motion-PRO: Add LED support Marian Balakowicz
2007-10-24 14:18   ` Grant Likely
2007-10-25 15:53     ` Marian Balakowicz
2007-10-23 23:14 ` [PATCH 10/11] [POWERPC] Promess Motion-PRO DTS Marian Balakowicz
2007-10-23 23:14 ` [PATCH 11/11] [POWERPC] Promess Motion-PRO defconfig Marian Balakowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4720AE67.3060902@semihalf.com \
    --to=m8@semihalf$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=olof@lixom$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox