From: Joseph Jezak <josejx@gentoo•org>
To: Dmitry Torokhov <dtor@insightbb•com>
Cc: Johannes Berg <johannes@sipsolutions•net>,
linuxppc-dev@ozlabs•org,
Joseph Jezak <josejx@woodpecker•gentoo.org>,
valderman@gmail•com
Subject: Re: [PATCH] Prevent appletouch message log spam on 17" PB
Date: Sun, 28 Oct 2007 22:34:39 -0400 [thread overview]
Message-ID: <472546BF.4010102@gentoo.org> (raw)
In-Reply-To: <200710282221.26241.dtor@insightbb.com>
Dmitry Torokhov wrote:
> Hi Joseph,
>
> On Sunday 28 October 2007 19:53, Joseph Jezak wrote:
>> Perhaps this was a debugging message? In any case, this printk
>> causes lots of message log spam on my PB G4 1.67" (PowerBook5,9).
>>
>> This removes the printk.
>>
>
> I don't think we want do delete this message outright, we just need
> to make sure we don't go through size detection when we re-initialize
> the device. After all it is unlikely that touchpad will change its
> size :)
>
> BTW, could you tell me what product ID your touchpad has?
>
>> Signed-off by: Joseph Jezak <josejx@gentoo•org>
>> ---
>>
>> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
>> index f132702..6c47641 100644
>> --- a/drivers/input/mouse/appletouch.c
>> +++ b/drivers/input/mouse/appletouch.c
>> @@ -433,7 +433,6 @@ static void atp_complete(struct urb* urb)
>> for (i = (atp_is_geyser_2(dev)?15:16); i < ATP_XSENSORS; i++) {
>> if (!dev->xy_cur[i]) continue;
>>
>> - printk("appletouch: 17\" model detected.\n");
>> if(atp_is_geyser_2(dev))
>> input_set_abs_params(dev->input, ABS_X, 0,
>> (20 - 1) *
>>
>
Sure, that's probably better. My touchpad is an 0x0214.
-Joe
prev parent reply other threads:[~2007-10-29 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 23:53 [PATCH] Prevent appletouch message log spam on 17" PB Joseph Jezak
2007-10-29 2:21 ` Dmitry Torokhov
2007-10-29 2:34 ` Joseph Jezak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472546BF.4010102@gentoo.org \
--to=josejx@gentoo$(echo .)org \
--cc=dtor@insightbb$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=josejx@woodpecker$(echo .)gentoo.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=valderman@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox