From: Valentine Barshak <vbarshak@ru•mvista.com>
To: tnt@blacksnow•net
Cc: linux-usb-devel@lists•sourceforge.net, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings
Date: Thu, 01 Nov 2007 15:44:16 +0300 [thread overview]
Message-ID: <4729CA20.6040905@ru.mvista.com> (raw)
In-Reply-To: <52304.213.186.37.16.1193915988.squirrel@www.opensources.be>
tnt@blacksnow•net wrote:
>>> USB_OHCI_BIG_ENDIAN_DESC/MMIO should always be enabled for ppc
>>> and USB_OHCI_LITTLE_ENDIAN is selected for USB_OHCI_HCD_PCI by default.
>
> I don't find those options useless. If you think the defauts are not the
> best change them but I find these options relevant. You don't always want
> the support for BE on PPC ... if the only controller you have is pci ...
> or if you're on a soc that use little endian ...
If I have just a pci controller, and don't expect to to find/use the
built-in one, why should I need the ohci-ppc-of driver then?
I'm not aware of a soc that uses little endian, but I think that LE/BE
still shouldn't be selected manually. It should be autoselected then,
the same way we select LE for PCI for example.
>
> Do we really need to stop supporting the old values right now ?
I've resubmitted the patches with the old mpc52xx bindings support.
Keeping old ohci-be/le stuff along with the new bindings doesn't look
good to me. However, I think we can live with the old ones and maybe
find a better way for OF ohci support later.
>
> IMHO, Changing to the usb-ohci with a property sounds fine to me if you
> really want to but don't drop support for the old values. They are not
> "bad". Change the dts to reflect the fact that the new "way" is preferred
> and a comment somewhere in the code and that should be fine.
OK
> Sylvain
>
Thanks,
Valentine.
next prev parent reply other threads:[~2007-11-01 12:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:22 [PATCH 0/2] USB: Rework OHCI PPC OF driver to support new bindings Valentine Barshak
2007-10-24 16:34 ` [PATCH 1/2] USB: Rework OHCI PPC OF for " Valentine Barshak
2007-10-24 22:05 ` Matt Sealey
2007-10-25 1:50 ` [linux-usb-devel] " David Brownell
2007-10-25 2:41 ` Grant Likely
2007-10-25 11:48 ` Valentine Barshak
2007-10-25 14:21 ` Grant Likely
2007-10-25 17:11 ` Valentine Barshak
2007-10-25 18:14 ` Matt Sealey
2007-10-25 18:13 ` Valentine Barshak
2007-10-25 18:10 ` Matt Sealey
2007-10-25 18:01 ` Matt Sealey
2007-10-25 18:50 ` Valentine Barshak
2007-10-25 22:02 ` Matt Sealey
2007-10-26 11:24 ` Valentine Barshak
2007-10-26 12:13 ` Valentine Barshak
2007-11-01 11:19 ` tnt
2007-11-01 12:44 ` Valentine Barshak [this message]
2007-11-01 13:46 ` [linux-usb-devel] " Dale Farnsworth
2007-10-24 16:35 ` [PATCH 2/2] PowerPC: Update USB OHCI DTS entires " Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4729CA20.6040905@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=linux-usb-devel@lists$(echo .)sourceforge.net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tnt@blacksnow$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox