From: Marian Balakowicz <m8@semihalf•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2 10/12] [POWERPC] Motion-PRO: Add LED support.
Date: Tue, 06 Nov 2007 12:58:12 +0100 [thread overview]
Message-ID: <473056D4.2040104@semihalf.com> (raw)
In-Reply-To: <20071104152716.a38dc9f7.sfr@canb.auug.org.au>
Hi Stephen,
Stephen Rothwell wrote:
> On Sun, 04 Nov 2007 00:53:11 +0100 Marian Balakowicz <m8@semihalf•com> wrote:
>> +++ b/drivers/leds/leds-motionpro.c
[snip]
>> +#include <asm/io.h>
>> +#include <asm/of_platform.h>
>
> You want <linux/of_platform.h> instead of <asm/..> and probably not
> <linux/platform_device.h> above.
[snip]
Thanks for comments, I'll apply your suggestions for v3 respin of the
patches.
Cheers,
m.
next prev parent reply other threads:[~2007-11-06 11:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 23:52 [PATCH v2 00/12] [POWERPC] Add TQM5200/CM5200/Motion-PRO board support Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 01/12] [POWERPC] Add 'model: ...' line to common show_cpuinfo() Marian Balakowicz
2007-11-04 22:17 ` David Gibson
2007-11-05 1:40 ` Olof Johansson
2007-11-03 23:52 ` [PATCH v2 02/12] [POWERPC] Add 'fsl, lpb' bus type for MPC5200 LocalPlus Bus Marian Balakowicz
2007-11-04 22:18 ` David Gibson
2007-11-03 23:52 ` [PATCH v2 03/12] [POWERPC] Add common mpc52xx_setup_pci() routine Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 04/12] [POWERPC] Add generic support for simple MPC5200 based boards Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 05/12] [POWERPC] Export mpc52xx_map_node() routine symbol Marian Balakowicz
2007-11-04 4:09 ` Stephen Rothwell
2007-11-06 12:23 ` Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 06/12] [POWERPC] TQM5200 DTS Marian Balakowicz
2007-11-05 0:47 ` David Gibson
2007-11-06 19:50 ` Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 07/12] [POWERPC] TQM5200 defconfig Marian Balakowicz
2007-11-03 23:52 ` [PATCH v2 08/12] [POWERPC] CM5200 DTS Marian Balakowicz
2007-11-05 0:50 ` David Gibson
2007-11-06 19:18 ` Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 09/12] [POWERPC] CM5200 defconfig Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 10/12] [POWERPC] Motion-PRO: Add LED support Marian Balakowicz
2007-11-04 4:27 ` Stephen Rothwell
2007-11-06 11:58 ` Marian Balakowicz [this message]
2007-11-03 23:53 ` [PATCH v2 11/12] [POWERPC] Promess Motion-PRO DTS Marian Balakowicz
2007-11-05 0:56 ` David Gibson
2007-11-06 20:02 ` Marian Balakowicz
2007-11-03 23:53 ` [PATCH v2 12/12] [POWERPC] Promess Motion-PRO defconfig Marian Balakowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473056D4.2040104@semihalf.com \
--to=m8@semihalf$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox