From: Marian Balakowicz <m8@semihalf•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v3 12/13] [POWERPC] Promess Motion-PRO DTS
Date: Fri, 09 Nov 2007 15:22:45 +0100 [thread overview]
Message-ID: <47346D35.1090303@semihalf.com> (raw)
In-Reply-To: <20071106224200.GE31367@localhost.localdomain>
David Gibson wrote:
> On Tue, Nov 06, 2007 at 09:06:34PM +0100, Marian Balakowicz wrote:
>> Add device tree source file for Motion-PRO board.
> [snip]
>> + motionpro-statusled@660 { // Motion-PRO status LED
>> + compatible = "promess,motionpro-statusled";
>> + reg = <660 10>;
>> + interrupts = <1 f 0>;
>> + interrupt-parent = <&mpc5200_pic>;
>> + blink-delay = <64>; // 100 msec
>> + };
>> +
>> + motionpro-readyled@670 { // Motion-PRO ready LED
>> + compatible = "promess,motionpro-readyled";
>> + reg = <670 10>;
>> + interrupts = <1 10 0>;
>> + interrupt-parent = <&mpc5200_pic>;
>> + };
>
> Is there actually any difference in behaviour betweeen the two LEDs?
> If not, they should probably have the same compatible value, and
> perhaps a "label" property or some such to associate them with a
> particular LED.
In fact they are identical, so I have used the same compatible
property and added label property do distinguish them.
> [snip]
>> + spi@f00 {
>> + device_type = "spi";
>
> No device_type!
Removed.
>> + compatible = "mpc5200b-spi","mpc5200-spi";
>> + reg = <f00 20>;
>> + interrupts = <2 d 0 2 e 0>;
>> + interrupt-parent = <&mpc5200_pic>;
>> + };
>> +
>> + usb@1000 {
>> + device_type = "usb-ohci-be";
>
> Nor here.
Removed.
> [snip]
>> + // PSC2 in spi master mode
>> + spi@2200 { // PSC2
>> + compatible = "mpc5200b-psc-spi","mpc5200-psc-spi";
>> + cell-index = <1>;
>
>>From your description, this is an incorrect usage of cell-index - it
> should *only* be used to index into SoC shared registers; never for
> logical numbering.
Again true, but the situation is similar to the one with the "serial"
node.
Cheers,
m.
next prev parent reply other threads:[~2007-11-09 14:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 20:04 [PATCH v3 00/13] [POWERPC] Add TQM5200/CM5200/Motion-PRO board support Marian Balakowicz
2007-11-06 20:04 ` [PATCH v3 01/13] [POWERPC] Add 'model: ...' line to common show_cpuinfo() Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 02/13] [POWERPC] Add 'fsl, lpb' bus type for MPC5200 LocalPlus Bus Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 03/13] [POWERPC] Add common mpc52xx_setup_pci() routine Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 04/13] [POWERPC] Add generic support for simple MPC5200 based boards Marian Balakowicz
2007-11-06 21:04 ` Grant Likely
2007-11-06 22:22 ` Wolfgang Denk
2007-11-06 23:25 ` Grant Likely
2007-11-09 14:43 ` Marian Balakowicz
2007-11-09 14:52 ` Grant Likely
2007-11-07 2:34 ` Stephen Rothwell
2007-11-09 14:11 ` Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 05/13] [POWERPC] Export mpc52xx_map_node() routine symbol Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 06/13] [POWERPC] Use EXPORT_SYMBOL_GPL for 52xx common routines symbol export Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 07/13] [POWERPC] TQM5200 DTS Marian Balakowicz
2007-11-06 22:36 ` David Gibson
2007-11-09 14:15 ` Marian Balakowicz
2007-11-06 20:05 ` [PATCH v3 08/13] [POWERPC] TQM5200 defconfig Marian Balakowicz
2007-11-06 20:06 ` [PATCH v3 09/13] [POWERPC] CM5200 DTS Marian Balakowicz
2007-11-06 20:06 ` [PATCH v3 10/13] [POWERPC] CM5200 defconfig Marian Balakowicz
2007-11-06 20:06 ` [PATCH v3 11/13] [POWERPC] Motion-PRO: Add LED support Marian Balakowicz
2007-11-06 20:06 ` [PATCH v3 12/13] [POWERPC] Promess Motion-PRO DTS Marian Balakowicz
2007-11-06 22:42 ` David Gibson
2007-11-09 14:22 ` Marian Balakowicz [this message]
2007-11-09 17:49 ` Grant Likely
2007-11-06 20:06 ` [PATCH v3 13/13] [POWERPC] Promess Motion-PRO defconfig Marian Balakowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47346D35.1090303@semihalf.com \
--to=m8@semihalf$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox