From: Marian Balakowicz <m8@semihalf•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v4 04/13] [POWERPC] Add generic support for simple MPC5200 based boards
Date: Mon, 12 Nov 2007 23:22:16 +0100 [thread overview]
Message-ID: <4738D218.9060503@semihalf.com> (raw)
In-Reply-To: <20071110113133.86aa3de2.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> On Fri, 09 Nov 2007 18:12:02 +0100 Marian Balakowicz <m8@semihalf•com> wrote:
>> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
>>
>> +static int __init mpc5200_simple_probe(void)
>> +{
>> + unsigned long node = of_get_flat_dt_root();
>
> You need to include asm/prom.h to use the flattened device tree accessors.
Right, but this one is already included in mpc52xx.h.
>> + /* list of the supported boards */
>> + const char *board[] = {
>> + "tqc,tqm5200",
>> + "promess,motionpro",
>> + "schindler,cm5200",
>> + NULL
>> + };
>
> Make that static.
Board table is no longer needed after kernel is initialized, it would
be nice to declare it static and __initdata, but that would be quite
ugly as it's a table of pointers and each string would require
separate statement too. If we don't do it then what's the benefit of
making it static?
Cheers,
m.
next prev parent reply other threads:[~2007-11-12 22:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 17:11 [PATCH v4 00/13] [POWERPC] Add TQM5200/CM5200/Motion-PRO board support Marian Balakowicz
2007-11-09 17:11 ` [PATCH v4 01/13] [POWERPC] Add 'model: ...' line to common show_cpuinfo() Marian Balakowicz
2007-11-09 17:11 ` [PATCH v4 02/13] [POWERPC] Add 'fsl, lpb' bus type for MPC5200 LocalPlus Bus Marian Balakowicz
2008-01-02 23:37 ` Grant Likely
2008-01-17 14:30 ` Marian Balakowicz
2007-11-09 17:11 ` [PATCH v4 03/13] [POWERPC] Add common mpc52xx_setup_pci() routine Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 04/13] [POWERPC] Add generic support for simple MPC5200 based boards Marian Balakowicz
2007-11-10 0:31 ` Stephen Rothwell
2007-11-12 22:22 ` Marian Balakowicz [this message]
2007-11-13 1:15 ` Stephen Rothwell
2007-11-10 12:43 ` Wolfgang Denk
2007-11-12 22:28 ` Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 05/13] [POWERPC] Export mpc52xx_map_node() routine symbol Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 06/13] [POWERPC] Use EXPORT_SYMBOL_GPL for 52xx common routines symbol export Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 07/13] [POWERPC] TQM5200 DTS Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 08/13] [POWERPC] TQM5200 defconfig Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 09/13] [POWERPC] CM5200 DTS Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 10/13] [POWERPC] CM5200 defconfig Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 11/13] [POWERPC] Motion-PRO: Add LED support Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 12/13] [POWERPC] Promess Motion-PRO DTS Marian Balakowicz
2007-11-09 17:12 ` [PATCH v4 13/13] [POWERPC] Promess Motion-PRO defconfig Marian Balakowicz
2007-11-09 17:20 ` [PATCH v4 00/13] [POWERPC] Add TQM5200/CM5200/Motion-PRO board support Grant Likely
2007-11-10 2:52 ` Grant Likely
2007-11-12 22:26 ` Marian Balakowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4738D218.9060503@semihalf.com \
--to=m8@semihalf$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox