Subject: Re: [PATCH v5 04/13] [POWERPC] Add generic support for simple MPC5200 based boards

From: Marian Balakowicz <[email-masked]>
Date: Thu, 15 Nov 2007 12:06:46 +0100

Hi Stephen,

Stephen Rothwell wrote:
> 
> On Wed, 14 Nov 2007 11:21:37 +0100 Marian Balakowicz <[email-masked]> wrote:
>> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
>> +#include <asm/time.h>
>> +#include <asm/machdep.h>
>> +#include <asm/mpc52xx.h>
> 
> You still need asm/prom.h because you use of_get_flat_dt_root() and
> of_flat_dt_is_compatible().
> 
>> +/* list of the supported boards */
>> +static const char *board[] __initdata = {
> 
> Unfortunately you can't use "const" and "__initdata", so just remove the
> "const".  (const changes the attributes on the section that __initdata is
> stored in.)

Arghh, too much of a hurry it seems, thanks for catching it.

Cheers,
m.