From: Clemens Koller <clemens.koller@anagramm•de>
To: Arnd Bergmann <arnd@arndb•de>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: Oops: of_platform_serial_probe
Date: Tue, 20 Nov 2007 13:49:33 +0100 [thread overview]
Message-ID: <4742D7DD.9040308@anagramm.de> (raw)
In-Reply-To: <200711201305.47753.arnd@arndb.de>
>> @@ -36,6 +36,10 @@ static int __devinit of_platform_serial_setup(struct of_device *ofdev,
>> memset(port, 0, sizeof *port);
>> spd = of_get_property(np, "current-speed", NULL);
>> clk = of_get_property(np, "clock-frequency", NULL);
>> + if (!spd) {
>> + dev_warn(&ofdev->dev, "no current-speed property set\n");
>> + return -ENODEV;
>> + }
>> if (!clk) {
>> dev_warn(&ofdev->dev, "no clock-frequency property set\n");
>> return -ENODEV;
>
> This looks wrong. Since the current-speed property is not mandated by open firmware,
> we should not error out here, but simply use the setting from the command line
> or whatever other defaults can be used. Not setting port->custom_divisor at all
> should do the job.
Understood... but then, my console just stops / gets reinitialized to some unknown
baudrate when I get to of_serial.c. :-(
Regards,
Clemens Koller
__________________________________
R&D Imaging Devices
Anagramm GmbH
Rupert-Mayer-Straße 45/1
Linhof Werksgelände
D-81379 München
Tel.089-741518-50
Fax 089-741518-19
http://www.anagramm-technology.com
prev parent reply other threads:[~2007-11-20 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 13:46 Oops: of_platform_serial_probe Clemens Koller
2007-11-19 15:04 ` Timur Tabi
2007-11-19 16:26 ` Clemens Koller
2007-11-19 16:34 ` Timur Tabi
2007-11-19 16:56 ` Arnd Bergmann
2007-11-20 10:52 ` Clemens Koller
2007-11-20 12:05 ` Arnd Bergmann
2007-11-20 12:49 ` Clemens Koller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4742D7DD.9040308@anagramm.de \
--to=clemens.koller@anagramm$(echo .)de \
--cc=arnd@arndb$(echo .)de \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox