Subject: Re: [PATCH resend 3/4] powerpc: Add EXPORT_SYMBOL for symbols required by fs_enet and cpm_uart

From: Jochen Friedrich <[email-masked]>
Date: Thu, 22 Nov 2007 18:27:23 +0100

Hi Grant,

> Is this really a good idea?  A globally accessable pointer to the region?

No it's not. But drivers are actually using the pointer and due to the
missing export, they currently don't compile as module.

>> +EXPORT_SYMBOL(cpm_setbrg);
> 
> EXPORT_SYMBOL_GPL?

Agreed.

Thanks,
Jochen