public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am•sony.com>
To: akpm@linux-foundation•org
Cc: Daniel Walker <dwalker@mvista•com>,
	matthias.kaehlcke@gmail•com, linux-kernel@vger•kernel.org,
	linux@bohmer•net, linuxppc-dev@ozlabs•org, mingo@elte•hu,
	kjwinchester@gmail•com
Subject: Re: [PATCH 1/3] ps3: vuart: fix error path locking
Date: Wed, 12 Dec 2007 18:00:12 -0800	[thread overview]
Message-ID: <4760922C.2060908@am.sony.com> (raw)
In-Reply-To: <20071213003028.676998182@mvista.com>

> This stray down would cause a permanent sleep which doesn't seem correct. 
> The other uses of this semaphore appear fairly mutex like it's even initialized
> with init_MUTEX() ..  So here a patch for removing this one down().
> 
> Signed-off-by: Daniel Walker <dwalker@mvista•com>
> 
> ---
>  drivers/ps3/ps3-vuart.c |    1 -
>  1 file changed, 1 deletion(-)


Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>


Looks, good. 
Andrew, Please apply.

-Geoff 

  reply	other threads:[~2007-12-13  2:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071213003023.117964080@mvista.com>
2007-12-12  8:00 ` [PATCH 1/3] ps3: vuart: fix error path locking Daniel Walker
2007-12-13  2:00   ` Geoff Levand [this message]
2007-12-19  1:10     ` Andrew Morton
2007-12-19  1:54       ` Daniel Walker
2007-12-19  3:04       ` Geoff Levand
2007-12-20 19:32         ` Daniel Walker
2007-12-20 20:06           ` Andrew Morton
2007-12-20 20:13             ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4760922C.2060908@am.sony.com \
    --to=geoffrey.levand@am$(echo .)sony.com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=dwalker@mvista$(echo .)com \
    --cc=kjwinchester@gmail$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@bohmer$(echo .)net \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=matthias.kaehlcke@gmail$(echo .)com \
    --cc=mingo@elte$(echo .)hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox