Subject: Re: [PATCH 4/4] [POWERPC] fsl_spi_init and users: stop using device_type = "spi"

From: Timur Tabi <[email-masked]>
Date: Wed, 19 Dec 2007 15:04:51 -0600

Anton Vorontsov wrote:

> diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
> index 3cf84d0..91bac51 100644
> --- a/arch/powerpc/sysdev/fsl_soc.c
> +++ b/arch/powerpc/sysdev/fsl_soc.c
> @@ -1242,7 +1242,7 @@ int __init fsl_spi_init(struct spi_board_info *board_infos,
>  	}
>  
>  	for (np = NULL, i = 1;
> -	     (np = of_find_compatible_node(np, "spi", "fsl_spi")) != NULL;
> +	     (np = of_find_compatible_node(np, NULL, "fsl,spi")) != NULL;

Can you keep the original code around to look for older device trees that are 
wrong?  Backwards compatibility is important.  I don't want to have to update 
the device tree just because I update the kernel.

-- 
Timur Tabi
Linux kernel developer at Freescale