From: Valentine Barshak <vbarshak@ru•mvista.com>
To: benh@kernel•crashing.org
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 11/20] [POWERPC] Wire up PCI on Bamboo board
Date: Thu, 20 Dec 2007 23:26:00 +0300 [thread overview]
Message-ID: <476ACFD8.1000506@ru.mvista.com> (raw)
In-Reply-To: <1198095967.18908.33.camel@pasglop>
Benjamin Herrenschmidt wrote:
> On Wed, 2007-12-19 at 16:34 +0300, Valentine Barshak wrote:
>
>>> --- linux-work.orig/arch/powerpc/boot/dts/bamboo.dts 2007-12-10 15:56:59.000000000 +1100
>>> +++ linux-work/arch/powerpc/boot/dts/bamboo.dts 2007-12-10 16:39:51.000000000 +1100
>>> @@ -239,10 +239,48 @@
>>> zmii-channel = <1>;
>>> };
>>> };
>>> +
>>> + PCI0: pci@ec000000 {
>>> + device_type = "pci";
>>> + #interrupt-cells = <1>;
>>> + #size-cells = <2>;
>>> + #address-cells = <3>;
>>> + compatible = "ibm,plb440ep-pci", "ibm,plb-pci";
>>> + primary;
>>> + reg = <0 eec00000 8 /* Config space access */
>>> + 0 eed80000 4 /* IACK */
>>> + 0 eed80000 4 /* Special cycle */
>>> + 0 ef480000 40>; /* Internal registers */
>> Why ef480000 here? IIRC, the docs say it should be ef400000, while
>> ef400040 - ef4fffff are reserved and can mirror local registers.
>
> Dunno... probably a typo, though it worked :-) I'll fix it up.
Just checked the ppc440ep user manual again.
Special cycle/IACK registers are at 0xeed00000 instead of 0xeed80000.
Looks like the same typo as in the internal registers.
It works because all these registers are mirrored at 0x80000 offset
(though it's claimed to be a reserved region).
Thanks,
Valentine.
>
> Ben.
>
>
next prev parent reply other threads:[~2007-12-20 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 7:38 [PATCH 11/20] [POWERPC] Wire up PCI on Bamboo board Benjamin Herrenschmidt
2007-12-19 13:34 ` Valentine Barshak
2007-12-19 20:26 ` Benjamin Herrenschmidt
2007-12-20 20:26 ` Valentine Barshak [this message]
2007-12-20 20:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476ACFD8.1000506@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox