From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Paul Mackerras <paulus@samba•org>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
"linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>
Subject: Re: [patch v2] PS3: Fix printing of os-area magic numbers
Date: Sat, 22 Dec 2007 20:54:23 -0800 [thread overview]
Message-ID: <476DE9FF.7070409@am.sony.com> (raw)
In-Reply-To: <18283.17563.790043.79740@cargo.ozlabs.ibm.com>
On 12/20/2007 08:44 PM, Paul Mackerras wrote:
> Geoff Levand writes:
>
>> Fix a bug in the printing of the os-area magic numbers which assumed that
>> magic numbers were zero terminated strings. The magic numbers are represented
>> in memory as integers. If the os-area sections are not initialized correctly
>> they could contained random data that would be printed to the display.
>
>> + u8 str[sizeof(h->magic_num) + 1];
>> + u8 *s, *d;
>> +
>> + for(s = h->magic_num, d = str; s < h->magic_num + sizeof(h->magic_num);
>> + s++, d++) {
>> + *d = isprint(*s) ? *s : '.';
>> + }
>> + d[sizeof(h->magic_num)] = 0;
>
> This last statement is wrong, because d has been incremented to point
> to the last byte of str already by this stage.
>
> It would be nicer if you pulled out the two instances of the for loop
> into a little helper function.
OK.
>> + for(s = (u8*)&db->magic_num, d = str;
>
> Why do you need the (u8*) cast in this case but not the other?
The types are different. The header magic is an array of u8, the db magic
is a u32.
-Geoff
next prev parent reply other threads:[~2007-12-23 4:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 22:24 [patch] PS3: Fix printing of os-area magic numbers Geoff Levand
2007-11-18 9:33 ` Geert Uytterhoeven
2007-11-22 22:08 ` [patch v2] " Geoff Levand
2007-12-21 4:44 ` Paul Mackerras
2007-12-23 4:54 ` Geoff Levand [this message]
2007-12-23 5:09 ` [patch v3] " Geoff Levand
2007-12-23 9:51 ` Geert Uytterhoeven
2007-12-23 17:20 ` Geoff Levand
2007-12-23 17:41 ` [patch v4] " Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476DE9FF.7070409@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox