Subject: Re: [PATCH v6] qe: add ability to upload QE firmware

From: Timur Tabi <[email-masked]>
Date: Tue, 08 Jan 2008 09:26:27 -0600

Stephen Rothwell wrote:

> If you use:
> 	for_each_child_of_node(qe, fw)
> You don't need to initialise 'fw' in its declararion.

I can't find for_each_child_of_node.  It's not in Kumar's for-2.6.25 branch.

> Why not:
> 	const u64 *iprop;
> 	int len;
> 
> 	iprop = of_get_property(fs, "extended-modes", &len);

Ok.

-- 
Timur Tabi
Linux kernel developer at Freescale