Subject: Re: Help with device tree binding for SMC serial

From: Scott Wood <[email-masked]>
Date: Wed, 09 Jan 2008 13:45:49 -0600

Rune Torgersen wrote:
> Hi
> 
> We're trying to get a SMC serial port on a8280 to work.
> I cannot find any ecxamples on the binding, so we've tried to make one.
> 
> is this anywhere close to workable?
> 
> serial@11a80 {
> 	device_type = "serial";
> 	compatible = "fsl,mpc8280-smc-uart",
> 				 "fsl,cpm2-smc-uart";
> 	reg = <11a80 10 87fc 2>;

The current binding has the actual parameter ram block as the second reg 
property, not the two-byte pointer.  If your firmware doesn't initialize 
the pointer, you'll have to do it in platform code.

> 	interrupts = <4 8>;
> 	interrupt-parent = <&PIC>;
> 	fsl,cpm-brg = <7>;
> 	fsl,cpm-command = <01000000>;
> };

cpm-command should be <1d000000> for SMC1.

Otherwise, it looks OK.

-Scott