Subject: Re: [PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog

From: Jochen Friedrich <[email-masked]>
Date: Thu, 17 Jan 2008 15:55:27 +0100

Hi Kumar,

> Why are you commenting on mpc83xx_wdt with respect to pq1_wdt?
> 
> Also, is this driver just for PQ1 platforms or PQ1 & PQ2?  If its just 
> pq1 we should probably call it pq1_wdt*

It should be for pq1, pq2 and pq2pro. However, i only have the possibility
to test this on pq1.

>> arch/powerpc/platforms/8xx/mpc86xads_setup.c |    5 +
>> arch/powerpc/platforms/8xx/mpc885ads_setup.c |    5 +
>> arch/powerpc/sysdev/Makefile                 |    3 +
>> arch/powerpc/sysdev/pq_wdt.c                 |  203 
>> +++++++++++++++++++++++
>> arch/powerpc/sysdev/pq_wdt.h                 |   28 ++++
>> drivers/watchdog/Kconfig                     |   13 ++-
>> drivers/watchdog/Makefile                    |    1 +
>> drivers/watchdog/pq_wdt.c                    |  225 
>> ++++++++++++++++++++++++++
>> 8 files changed, 482 insertions(+), 1 deletions(-)
>> create mode 100644 arch/powerpc/sysdev/pq_wdt.c
>> create mode 100644 arch/powerpc/sysdev/pq_wdt.h
>> create mode 100644 drivers/watchdog/pq_wdt.c
> 
> What are the bits in sysdev/pq_wdt.{c,h}.  Why aren't these just in 
> drivers/watchdog?

These are the parts needed to boot a device with activated watchdog. If a 
bootloader like u-boot activates the watchdog, it can't be deactivated again
and needs to be reset at regular intervals. This is done using a kernel timer.
The driver in drivers/watchdog disables the timer as soon as the wdt device
is opened.

Thanks,
Jochen