From: Jochen Friedrich <jochen@scram•de>
To: Bryan Wu <cooloney.lkml@gmail•com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>,
"Kernel, Linux" <linux-kernel@vger•kernel.org>,
Jean Delvare <khali@linux-fr•org>, Linux I2C <i2c@lm-sensors•org>,
Scott Wood <scottwood@freescale•com>
Subject: Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers
Date: Mon, 28 Jan 2008 19:45:52 +0100 [thread overview]
Message-ID: <479E22E0.9010105@scram.de> (raw)
In-Reply-To: <386072610801280921q3e96bfc1v40ad09660c0f7ad8@mail.gmail.com>
Hi Bryan,
>> +
>> + /* register new adapter to i2c module... */
>> +
>> + result = i2c_add_adapter(&cpm->adap);
>
> As I was pointed before, please use the new style i2c driver interface:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=991dee591a99d035796a8c194eb1796cc020e142
AFAIK, the device tree currently doesn't provide an adapter id. If we're going to add this property, this would be
needed on other of_platform i2c drivers, as well.
Thanks,
Jochen
prev parent reply other threads:[~2008-01-28 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 17:11 [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers Jochen Friedrich
2008-01-28 16:49 ` Scott Wood
2008-01-28 17:01 ` Kumar Gala
2008-01-28 17:21 ` Bryan Wu
2008-01-28 18:45 ` Jochen Friedrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479E22E0.9010105@scram.de \
--to=jochen@scram$(echo .)de \
--cc=cooloney.lkml@gmail$(echo .)com \
--cc=i2c@lm-sensors$(echo .)org \
--cc=khali@linux-fr$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox