From: Mike Travis <travis@sgi•com>
To: Ingo Molnar <mingo@elte•hu>
Cc: Tony Luck <tony.luck@intel•com>,
linux-ia64@vger•kernel.org, linuxppc-dev@ozlabs•org,
Sam Ravnborg <sam@ravnborg•org>,
Rusty Russell <rusty@rustcorp•com.au>,
linux-kernel@vger•kernel.org, Andi Kleen <ak@suse•de>,
linux-mm@kvack•org,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
Thomas Gleixner <tglx@linutronix•de>,
Linus Torvalds <torvalds@linux-foundation•org>,
David Miller <davem@davemloft•net>,
Christoph Lameter <clameter@sgi•com>
Subject: Re: [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA linux-2.6.git
Date: Wed, 30 Jan 2008 13:57:31 -0800 [thread overview]
Message-ID: <47A0F2CB.3070204@sgi.com> (raw)
In-Reply-To: <20080130215015.GA28242@elte.hu>
Ingo Molnar wrote:
> * travis@sgi•com <travis@sgi•com> wrote:
>
>> Change:
>> config ARCH_SETS_UP_PER_CPU_AREA
>> to:
>> config HAVE_SETUP_PER_CPU_AREA
>
> undocumented change:
>
>> config ARCH_NO_VIRT_TO_BUS
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -380,6 +380,8 @@ static void __init setup_per_cpu_areas(v
>>
>> /* Copy section for each CPU (we discard the original) */
>> size = ALIGN(PERCPU_ENOUGH_ROOM, PAGE_SIZE);
>> + printk(KERN_INFO
>> + "PERCPU: Allocating %lu bytes of per cpu data (main)\n", size);
>> ptr = alloc_bootmem_pages(size * nr_possible_cpus);
>
> but looks fine to me.
>
> Ingo
Sorry, I should have noted this. The primary reason I put this in, is
that if the HAVE_SETUP_PER_CPU_AREA is not set when it should be, then
the incorrect (generic) setup_per_cpu_areas() is used and weird things
happen later on. The above line documents that PERCPU has been allocated
by init/main.c version of this function in the startup messages.
(Since it's a static function, there is no "duplicate label" error in
the linker.)
Thanks,
Mike
prev parent reply other threads:[~2008-01-30 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080130180940.022172000@sgi.com>
2008-01-30 18:09 ` [PATCH 1/6] modules: Fold percpu_modcopy into module.c linux-2.6.git travis
2008-01-30 18:09 ` [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA linux-2.6.git travis
2008-01-30 21:50 ` Ingo Molnar
2008-01-30 21:57 ` Mike Travis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A0F2CB.3070204@sgi.com \
--to=travis@sgi$(echo .)com \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=ak@suse$(echo .)de \
--cc=clameter@sgi$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sam@ravnborg$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox